* [LTP] [PATCH] pidns30 pidns31: syscall mq_open() failed EFAULT(Bad address)
@ 2012-12-25 7:25 Monson Shao
2012-12-25 7:42 ` Caspar Zhang
0 siblings, 1 reply; 5+ messages in thread
From: Monson Shao @ 2012-12-25 7:25 UTC (permalink / raw)
To: ltp-list
'man 3 mq_open' said mq_open() can take 2 or 4 arguments, but the implement
syscall(__NR_mq_open, ...) takes 4, according to [1].
Manually tested on kernel-3.6.0 with glibc-2.16 .
[1] glibc/sysdeps/unix/sysv/linux/mq_open.c:55
Signed-off-by: Monson Shao <jshao@redhat.com>
---
testcases/kernel/containers/pidns/pidns30.c | 2 +-
testcases/kernel/containers/pidns/pidns31.c | 2 +-
2 个文件被修改，插入 2 行(+)，删除 2 行(-)
diff --git a/testcases/kernel/containers/pidns/pidns30.c b/testcases/kernel/containers/pidns/pidns30.c
index 71e87c1..75c736b 100644
--- a/testcases/kernel/containers/pidns/pidns30.c
+++ b/testcases/kernel/containers/pidns/pidns30.c
@@ -186,7 +186,7 @@ int child_fn(void *arg)
while (read(father_to_child[0], buf, 1) != 1)
sleep(1);
- mqd = syscall(__NR_mq_open, mqname, O_RDONLY);
+ mqd = syscall(__NR_mq_open, mqname, O_RDONLY, 0, NULL);
if (mqd == -1) {
perror("mq_open failed");
return 1;
diff --git a/testcases/kernel/containers/pidns/pidns31.c b/testcases/kernel/containers/pidns/pidns31.c
index 2a07489..1498d16 100644
--- a/testcases/kernel/containers/pidns/pidns31.c
+++ b/testcases/kernel/containers/pidns/pidns31.c
@@ -177,7 +177,7 @@ int child_fn(void *arg)
}
tst_resm(TINFO, "cinit: my father is ready to receive a message");
- mqd = syscall(__NR_mq_open, mqname, O_WRONLY);
+ mqd = syscall(__NR_mq_open, mqname, O_WRONLY, 0, NULL);
if (mqd == (mqd_t) - 1) {
tst_resm(TBROK, "cinit: mq_open() failed (%s)",
strerror(errno));
--
1.7.11.7
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] pidns30 pidns31: syscall mq_open() failed EFAULT(Bad address)
2012-12-25 7:25 [LTP] [PATCH] pidns30 pidns31: syscall mq_open() failed EFAULT(Bad address) Monson Shao
@ 2012-12-25 7:42 ` Caspar Zhang
2012-12-25 11:23 ` Monson Shao
0 siblings, 1 reply; 5+ messages in thread
From: Caspar Zhang @ 2012-12-25 7:42 UTC (permalink / raw)
To: Monson Shao; +Cc: ltp-list
On 12/25/2012 03:25 PM, Monson Shao wrote:
> 'man 3 mq_open' said mq_open() can take 2 or 4 arguments, but the implement
> syscall(__NR_mq_open, ...) takes 4, according to [1].
>
> Manually tested on kernel-3.6.0 with glibc-2.16 .
>
> [1] glibc/sysdeps/unix/sysv/linux/mq_open.c:55
will this change the result on old kernel/glibc?
Caspar
>
> Signed-off-by: Monson Shao <jshao@redhat.com>
> ---
> testcases/kernel/containers/pidns/pidns30.c | 2 +-
> testcases/kernel/containers/pidns/pidns31.c | 2 +-
> 2 个文件被修改，插入 2 行(+)，删除 2 行(-)
>
> diff --git a/testcases/kernel/containers/pidns/pidns30.c b/testcases/kernel/containers/pidns/pidns30.c
> index 71e87c1..75c736b 100644
> --- a/testcases/kernel/containers/pidns/pidns30.c
> +++ b/testcases/kernel/containers/pidns/pidns30.c
> @@ -186,7 +186,7 @@ int child_fn(void *arg)
> while (read(father_to_child[0], buf, 1) != 1)
> sleep(1);
>
> - mqd = syscall(__NR_mq_open, mqname, O_RDONLY);
> + mqd = syscall(__NR_mq_open, mqname, O_RDONLY, 0, NULL);
> if (mqd == -1) {
> perror("mq_open failed");
> return 1;
> diff --git a/testcases/kernel/containers/pidns/pidns31.c b/testcases/kernel/containers/pidns/pidns31.c
> index 2a07489..1498d16 100644
> --- a/testcases/kernel/containers/pidns/pidns31.c
> +++ b/testcases/kernel/containers/pidns/pidns31.c
> @@ -177,7 +177,7 @@ int child_fn(void *arg)
> }
> tst_resm(TINFO, "cinit: my father is ready to receive a message");
>
> - mqd = syscall(__NR_mq_open, mqname, O_WRONLY);
> + mqd = syscall(__NR_mq_open, mqname, O_WRONLY, 0, NULL);
> if (mqd == (mqd_t) - 1) {
> tst_resm(TBROK, "cinit: mq_open() failed (%s)",
> strerror(errno));
>
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] pidns30 pidns31: syscall mq_open() failed EFAULT(Bad address)
2012-12-25 7:42 ` Caspar Zhang
@ 2012-12-25 11:23 ` Monson Shao
2012-12-26 2:57 ` Caspar Zhang
0 siblings, 1 reply; 5+ messages in thread
From: Monson Shao @ 2012-12-25 11:23 UTC (permalink / raw)
To: Caspar Zhang; +Cc: ltp-list
On Tue, 2012-12-25 at 15:42 +0800, Caspar Zhang wrote:
> On 12/25/2012 03:25 PM, Monson Shao wrote:
> > 'man 3 mq_open' said mq_open() can take 2 or 4 arguments, but the implement
> > syscall(__NR_mq_open, ...) takes 4, according to [1].
> >
> > Manually tested on kernel-3.6.0 with glibc-2.16 .
> >
> > [1] glibc/sysdeps/unix/sysv/linux/mq_open.c:55
>
> will this change the result on old kernel/glibc?
>
> Caspar
I haven't tested it on old kernel/glibc, but 4 arguments should always
be acceptable, since this usage exists in the same file [2].
[2] testcases/kernel/containers/pidns/pidns30.c:255
>
> >
> > Signed-off-by: Monson Shao <jshao@redhat.com>
> > ---
> > testcases/kernel/containers/pidns/pidns30.c | 2 +-
> > testcases/kernel/containers/pidns/pidns31.c | 2 +-
> > 2 个文件被修改，插入 2 行(+)，删除 2 行(-)
> >
> > diff --git a/testcases/kernel/containers/pidns/pidns30.c b/testcases/kernel/containers/pidns/pidns30.c
> > index 71e87c1..75c736b 100644
> > --- a/testcases/kernel/containers/pidns/pidns30.c
> > +++ b/testcases/kernel/containers/pidns/pidns30.c
> > @@ -186,7 +186,7 @@ int child_fn(void *arg)
> > while (read(father_to_child[0], buf, 1) != 1)
> > sleep(1);
> >
> > - mqd = syscall(__NR_mq_open, mqname, O_RDONLY);
> > + mqd = syscall(__NR_mq_open, mqname, O_RDONLY, 0, NULL);
> > if (mqd == -1) {
> > perror("mq_open failed");
> > return 1;
> > diff --git a/testcases/kernel/containers/pidns/pidns31.c b/testcases/kernel/containers/pidns/pidns31.c
> > index 2a07489..1498d16 100644
> > --- a/testcases/kernel/containers/pidns/pidns31.c
> > +++ b/testcases/kernel/containers/pidns/pidns31.c
> > @@ -177,7 +177,7 @@ int child_fn(void *arg)
> > }
> > tst_resm(TINFO, "cinit: my father is ready to receive a message");
> >
> > - mqd = syscall(__NR_mq_open, mqname, O_WRONLY);
> > + mqd = syscall(__NR_mq_open, mqname, O_WRONLY, 0, NULL);
> > if (mqd == (mqd_t) - 1) {
> > tst_resm(TBROK, "cinit: mq_open() failed (%s)",
> > strerror(errno));
> >
>
--
Monson Shao
Kernel QA
#29 @NAY - Beijing, China - GMT+08:00
IRC: monson (#kernel-qe, #eng-china)
Internal: 83 88384
External: +86 10 6260 8384
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] pidns30 pidns31: syscall mq_open() failed EFAULT(Bad address)
2012-12-25 11:23 ` Monson Shao
@ 2012-12-26 2:57 ` Caspar Zhang
2012-12-26 3:37 ` Wanlong Gao
0 siblings, 1 reply; 5+ messages in thread
From: Caspar Zhang @ 2012-12-26 2:57 UTC (permalink / raw)
To: Monson Shao; +Cc: ltp-list
On 12/25/2012 07:23 PM, Monson Shao wrote:
> On Tue, 2012-12-25 at 15:42 +0800, Caspar Zhang wrote:
>> On 12/25/2012 03:25 PM, Monson Shao wrote:
>>> 'man 3 mq_open' said mq_open() can take 2 or 4 arguments, but the implement
>>> syscall(__NR_mq_open, ...) takes 4, according to [1].
>>>
>>> Manually tested on kernel-3.6.0 with glibc-2.16 .
>>>
>>> [1] glibc/sysdeps/unix/sysv/linux/mq_open.c:55
>>
>> will this change the result on old kernel/glibc?
>>
>> Caspar
> I haven't tested it on old kernel/glibc, but 4 arguments should always
> be acceptable, since this usage exists in the same file [2].
Makes sense.
Reviewed-by: Caspar Zhang <caspar@casparzhang.com>
>
> [2] testcases/kernel/containers/pidns/pidns30.c:255
>>
>>>
>>> Signed-off-by: Monson Shao <jshao@redhat.com>
>>> ---
>>> testcases/kernel/containers/pidns/pidns30.c | 2 +-
>>> testcases/kernel/containers/pidns/pidns31.c | 2 +-
>>> 2 个文件被修改，插入 2 行(+)，删除 2 行(-)
>>>
>>> diff --git a/testcases/kernel/containers/pidns/pidns30.c b/testcases/kernel/containers/pidns/pidns30.c
>>> index 71e87c1..75c736b 100644
>>> --- a/testcases/kernel/containers/pidns/pidns30.c
>>> +++ b/testcases/kernel/containers/pidns/pidns30.c
>>> @@ -186,7 +186,7 @@ int child_fn(void *arg)
>>> while (read(father_to_child[0], buf, 1) != 1)
>>> sleep(1);
>>>
>>> - mqd = syscall(__NR_mq_open, mqname, O_RDONLY);
>>> + mqd = syscall(__NR_mq_open, mqname, O_RDONLY, 0, NULL);
>>> if (mqd == -1) {
>>> perror("mq_open failed");
>>> return 1;
>>> diff --git a/testcases/kernel/containers/pidns/pidns31.c b/testcases/kernel/containers/pidns/pidns31.c
>>> index 2a07489..1498d16 100644
>>> --- a/testcases/kernel/containers/pidns/pidns31.c
>>> +++ b/testcases/kernel/containers/pidns/pidns31.c
>>> @@ -177,7 +177,7 @@ int child_fn(void *arg)
>>> }
>>> tst_resm(TINFO, "cinit: my father is ready to receive a message");
>>>
>>> - mqd = syscall(__NR_mq_open, mqname, O_WRONLY);
>>> + mqd = syscall(__NR_mq_open, mqname, O_WRONLY, 0, NULL);
>>> if (mqd == (mqd_t) - 1) {
>>> tst_resm(TBROK, "cinit: mq_open() failed (%s)",
>>> strerror(errno));
>>>
>>
>
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] pidns30 pidns31: syscall mq_open() failed EFAULT(Bad address)
2012-12-26 2:57 ` Caspar Zhang
@ 2012-12-26 3:37 ` Wanlong Gao
0 siblings, 0 replies; 5+ messages in thread
From: Wanlong Gao @ 2012-12-26 3:37 UTC (permalink / raw)
To: Monson Shao; +Cc: ltp-list
On 12/26/2012 10:57 AM, Caspar Zhang wrote:
> On 12/25/2012 07:23 PM, Monson Shao wrote:
>> On Tue, 2012-12-25 at 15:42 +0800, Caspar Zhang wrote:
>>> On 12/25/2012 03:25 PM, Monson Shao wrote:
>>>> 'man 3 mq_open' said mq_open() can take 2 or 4 arguments, but the implement
>>>> syscall(__NR_mq_open, ...) takes 4, according to [1].
>>>>
>>>> Manually tested on kernel-3.6.0 with glibc-2.16 .
>>>>
>>>> [1] glibc/sysdeps/unix/sysv/linux/mq_open.c:55
>>>
>>> will this change the result on old kernel/glibc?
>>>
>>> Caspar
>> I haven't tested it on old kernel/glibc, but 4 arguments should always
>> be acceptable, since this usage exists in the same file [2].
>
> Makes sense.
>
> Reviewed-by: Caspar Zhang <caspar@casparzhang.com>
Applied, thank you.
Wanlong Gao
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-26 3:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-25 7:25 [LTP] [PATCH] pidns30 pidns31: syscall mq_open() failed EFAULT(Bad address) Monson Shao
2012-12-25 7:42 ` Caspar Zhang
2012-12-25 11:23 ` Monson Shao
2012-12-26 2:57 ` Caspar Zhang
2012-12-26 3:37 ` Wanlong Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox