From: Zhouping Liu <zliu@redhat.com>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: LTP List <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH v2 0/2] updated create_same_memory() inside lib/mem.c
Date: Fri, 04 Jan 2013 15:21:03 +0800 [thread overview]
Message-ID: <50E682DF.3050901@redhat.com> (raw)
In-Reply-To: <50E67F91.106@casparzhang.com>
On 01/04/2013 03:06 PM, Caspar Zhang wrote:
> On 01/04/2013 02:12 PM, Zhouping Liu wrote:
>> changed in v2:
>> - modified '_function_name' as 'function_name'
>> - added 'static' key word for internal function
>> - updated a little commit log
>>
>> Zhouping Liu (2):
>> mm/lib: rewrote create_same_memory()
>> mm/include: removed the global var 'memory'
>>
>> testcases/kernel/mem/include/_private.h | 2 +-
>> testcases/kernel/mem/include/mem.h | 5 -
>> testcases/kernel/mem/lib/mem.c | 425
>> +++++++++++++-------------------
>> 3 files changed, 170 insertions(+), 262 deletions(-)
>>
>
> Since there is no function updated in the patch, I'm OK to apply it if
> a unit-test is executed (better testing in a wide range of systems)
> and get ACKs from other reviewers. Zhouping, would you mind pasting
> some test details against your patch before we apply it?
This is an example of output log with the patch on Fedora 17:
[root@ZhoupingLiu ksm]# ./ksm01 -s 1 -n 6
ksm01 0 TINFO : child 0 stops.
ksm01 0 TINFO : child 1 stops.
ksm01 0 TINFO : child 2 stops.
ksm01 0 TINFO : child 3 stops.
ksm01 0 TINFO : wait for all children to stop.
ksm01 0 TINFO : child 4 stops.
ksm01 0 TINFO : child 5 stops.
ksm01 0 TINFO : KSM merging...
ksm01 0 TINFO : resume all children.
ksm01 0 TINFO : child 0 continues...
ksm01 0 TINFO : child 1 continues...
ksm01 0 TINFO : child 0 allocates 1 MB filled with 'c'
ksm01 0 TINFO : child 1 allocates 1 MB filled with 'a'
ksm01 0 TINFO : child 4 continues...
ksm01 0 TINFO : child 4 allocates 1 MB filled with 'c'
ksm01 0 TINFO : child 2 continues...
ksm01 0 TINFO : child 2 allocates 1 MB filled with 'a'
ksm01 0 TINFO : child 3 continues...
ksm01 0 TINFO : child 3 allocates 1 MB filled with 'c'
ksm01 0 TINFO : child 0 stops.
ksm01 0 TINFO : child 2 stops.
ksm01 0 TINFO : child 3 stops.
ksm01 0 TINFO : child 5 continues...
ksm01 0 TINFO : child 5 allocates 1 MB filled with 'c'
ksm01 0 TINFO : child 4 stops.
ksm01 0 TINFO : child 1 stops.
ksm01 0 TINFO : child 5 stops.
ksm01 0 TINFO : ksm daemon takes 20s to scan all mergeable pages
ksm01 0 TINFO : check!
ksm01 0 TINFO : run is 1.
ksm01 0 TINFO : pages_shared is 2.
ksm01 0 TINFO : pages_sharing is 1534.
ksm01 0 TINFO : pages_volatile is 0.
ksm01 0 TINFO : pages_unshared is 0.
ksm01 0 TINFO : sleep_millisecs is 0.
ksm01 0 TINFO : pages_to_scan is 1536.
ksm01 0 TINFO : wait for all children to stop.
ksm01 0 TINFO : resume all children.
ksm01 0 TINFO : child 1 verifies memory content.
ksm01 0 TINFO : child 0 verifies memory content.
ksm01 0 TINFO : child 2 verifies memory content.
ksm01 0 TINFO : child 1 continues...
ksm01 0 TINFO : child 0 continues...
ksm01 0 TINFO : child 2 continues...
ksm01 0 TINFO : child 1 allocates 1 MB filled with 'b'
ksm01 0 TINFO : child 0 allocates 1 MB filled with 'c'
ksm01 0 TINFO : child 2 allocates 1 MB filled with 'a'
ksm01 0 TINFO : child 2 stops.
ksm01 0 TINFO : child 4 verifies memory content.
ksm01 0 TINFO : child 5 verifies memory content.
ksm01 0 TINFO : child 0 stops.
ksm01 0 TINFO : child 1 stops.
ksm01 0 TINFO : child 3 verifies memory content.
ksm01 0 TINFO : child 4 continues...
ksm01 0 TINFO : child 5 continues...
ksm01 0 TINFO : child 5 allocates 1 MB filled with 'c'
ksm01 0 TINFO : child 4 allocates 1 MB filled with 'c'
ksm01 0 TINFO : child 3 continues...
ksm01 0 TINFO : child 3 allocates 1 MB filled with 'c'
ksm01 0 TINFO : child 5 stops.
ksm01 0 TINFO : child 3 stops.
ksm01 0 TINFO : child 4 stops.
ksm01 0 TINFO : ksm daemon takes 20s to scan all mergeable pages
ksm01 0 TINFO : check!
ksm01 0 TINFO : run is 1.
ksm01 0 TINFO : pages_shared is 3.
ksm01 0 TINFO : pages_sharing is 1533.
ksm01 0 TINFO : pages_volatile is 0.
ksm01 0 TINFO : pages_unshared is 0.
ksm01 0 TINFO : sleep_millisecs is 0.
ksm01 0 TINFO : pages_to_scan is 1536.
ksm01 0 TINFO : wait for all children to stop.
ksm01 0 TINFO : resume all children.
ksm01 0 TINFO : child 1 verifies memory content.
ksm01 0 TINFO : child 0 verifies memory content.
ksm01 0 TINFO : child 2 verifies memory content.
ksm01 0 TINFO : child 1 continues...
ksm01 0 TINFO : child 1 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 0 continues...
ksm01 0 TINFO : child 2 continues...
ksm01 0 TINFO : child 0 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 2 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 3 verifies memory content.
ksm01 0 TINFO : child 3 continues...
ksm01 0 TINFO : child 3 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 1 stops.
ksm01 0 TINFO : child 0 stops.
ksm01 0 TINFO : child 2 stops.
ksm01 0 TINFO : child 5 verifies memory content.
ksm01 0 TINFO : child 4 verifies memory content.
ksm01 0 TINFO : child 5 continues...
ksm01 0 TINFO : child 5 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 3 stops.
ksm01 0 TINFO : child 4 continues...
ksm01 0 TINFO : child 4 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 5 stops.
ksm01 0 TINFO : child 4 stops.
ksm01 0 TINFO : ksm daemon takes 20s to scan all mergeable pages
ksm01 0 TINFO : check!
ksm01 0 TINFO : run is 1.
ksm01 0 TINFO : pages_shared is 1.
ksm01 0 TINFO : pages_sharing is 1535.
ksm01 0 TINFO : pages_volatile is 0.
ksm01 0 TINFO : pages_unshared is 0.
ksm01 0 TINFO : sleep_millisecs is 0.
ksm01 0 TINFO : pages_to_scan is 1536.
ksm01 0 TINFO : wait for all children to stop.
ksm01 0 TINFO : resume all children.
ksm01 0 TINFO : child 1 verifies memory content.
ksm01 0 TINFO : child 0 verifies memory content.
ksm01 0 TINFO : child 2 verifies memory content.
ksm01 0 TINFO : child 4 verifies memory content.
ksm01 0 TINFO : child 1 continues...
ksm01 0 TINFO : child 1 allocates 1 MB filled with 'd' except
one page with 'e'
ksm01 0 TINFO : child 0 continues...
ksm01 0 TINFO : child 2 continues...
ksm01 0 TINFO : child 0 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 2 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 4 continues...
ksm01 0 TINFO : child 4 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 1 stops.
ksm01 0 TINFO : child 0 stops.
ksm01 0 TINFO : child 2 stops.
ksm01 0 TINFO : child 3 verifies memory content.
ksm01 0 TINFO : child 5 verifies memory content.
ksm01 0 TINFO : child 3 continues...
ksm01 0 TINFO : child 3 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 4 stops.
ksm01 0 TINFO : child 5 continues...
ksm01 0 TINFO : child 5 allocates 1 MB filled with 'd'
ksm01 0 TINFO : child 3 stops.
ksm01 0 TINFO : child 5 stops.
ksm01 0 TINFO : ksm daemon takes 20s to scan all mergeable pages
ksm01 0 TINFO : check!
ksm01 0 TINFO : run is 1.
ksm01 0 TINFO : pages_shared is 1.
ksm01 0 TINFO : pages_sharing is 1534.
ksm01 0 TINFO : pages_volatile is 0.
ksm01 0 TINFO : pages_unshared is 1.
ksm01 0 TINFO : sleep_millisecs is 0.
ksm01 0 TINFO : pages_to_scan is 1536.
ksm01 0 TINFO : wait for all children to stop.
ksm01 0 TINFO : KSM unmerging...
ksm01 0 TINFO : resume all children.
ksm01 0 TINFO : child 1 verifies memory content.
ksm01 0 TINFO : child 1 verifies memory content.
ksm01 0 TINFO : child 0 verifies memory content.
ksm01 0 TINFO : child 4 verifies memory content.
ksm01 0 TINFO : child 4 finished.
ksm01 0 TINFO : child 1 finished.
ksm01 0 TINFO : child 0 finished.
ksm01 0 TINFO : child 5 verifies memory content.
ksm01 0 TINFO : child 5 finished.
ksm01 0 TINFO : child 2 verifies memory content.
ksm01 0 TINFO : child 3 verifies memory content.
ksm01 0 TINFO : child 2 finished.
ksm01 0 TINFO : child 3 finished.
ksm01 0 TINFO : ksm daemon takes 10s to scan all mergeable pages
ksm01 0 TINFO : check!
ksm01 0 TINFO : run is 2.
ksm01 0 TINFO : pages_shared is 0.
ksm01 0 TINFO : pages_sharing is 0.
ksm01 0 TINFO : pages_volatile is 0.
ksm01 0 TINFO : pages_unshared is 0.
ksm01 0 TINFO : sleep_millisecs is 0.
ksm01 0 TINFO : pages_to_scan is 1536.
ksm01 0 TINFO : stop KSM.
ksm01 0 TINFO : ksm daemon takes 10s to scan all mergeable pages
ksm01 0 TINFO : check!
ksm01 0 TINFO : run is 0.
ksm01 0 TINFO : pages_shared is 0.
ksm01 0 TINFO : pages_sharing is 0.
ksm01 0 TINFO : pages_volatile is 0.
ksm01 0 TINFO : pages_unshared is 0.
ksm01 0 TINFO : sleep_millisecs is 0.
ksm01 0 TINFO : pages_to_scan is 1536.
Thanks,
Zhouping
------------------------------------------------------------------------------
Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
much more. Get web development skills now with LearnDevNow -
350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122812
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-01-04 7:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 6:12 [LTP] [PATCH v2 0/2] updated create_same_memory() inside lib/mem.c Zhouping Liu
2013-01-04 6:12 ` [LTP] [PATCH v2 1/2] mm/lib: rewrote create_same_memory() Zhouping Liu
2013-01-08 5:57 ` Wanlong Gao
2013-01-14 1:45 ` Wanlong Gao
2013-01-04 6:12 ` [LTP] [PATCH v3 2/2] mm/include: removed the global var 'memory' Zhouping Liu
2013-01-08 5:57 ` Wanlong Gao
2013-01-14 1:45 ` Wanlong Gao
2013-01-04 7:06 ` [LTP] [PATCH v2 0/2] updated create_same_memory() inside lib/mem.c Caspar Zhang
2013-01-04 7:21 ` Zhouping Liu [this message]
2013-01-04 7:31 ` Caspar Zhang
2013-01-04 15:29 ` Zhouping Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E682DF.3050901@redhat.com \
--to=zliu@redhat.com \
--cc=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox