Re: [LTP] [PATCH v2 1/2] mm/lib: rewrote create_same_memory()

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 01/04/2013 02:12 PM, Zhouping Liu wrote:
> create_same_memory() was too large and contained lots of duplicated codes,
> and it's a little hard-coding, so that it's not easy to read and
> extend it for new case.
> 
> I splited it for five sub-functions:
> 
>   ksm_child_memset();
>   create_ksm_child();
>   stop_ksm_children();
>   resume_ksm_children();
>   create_smae_memory();
> 
> Also I intruduced a data struct to control the mergeable data:
> 
>   struct ksm_merge_data {
>         char data;
>         int mergeable_size;
>   };
> 
> Signed-off-by: Zhouping Liu <zliu@redhat.com>

I have no objection.

Acked-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

Thanks,
Wanlong Gao



------------------------------------------------------------------------------
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills now (including 2012) with LearnDevNow -
200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only - learn more at:
http://p.sf.net/sfu/learnmore_122512
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list