From: Caspar Zhang <caspar@casparzhang.com>
To: Eryu Guan <eguan@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] syscalls/open11: new open(2) test case
Date: Mon, 04 Feb 2013 12:55:34 +0800 [thread overview]
Message-ID: <510F3F46.2010205@casparzhang.com> (raw)
In-Reply-To: <1359948132-26248-1-git-send-email-eguan@redhat.com>
On 02/04/2013 11:22 AM, Eryu Guan wrote:
>
> In addition to existing open(2) tests, add more basic tests and make
> sure open(2) works and handles error conditions correctly.
>
> There are 28 test cases:
> 1. Open regular file O_RDONLY
> 2. Open regular file O_WRONLY
> 3. Open regular file O_RDWR
> 4. Open regular file O_RDWR | O_SYNC
> 5. Open regular file O_RDWR | O_TRUNC
> 6. Open dir O_RDONLY
> 7. Open dir O_RDWR, expect EISDIR
> 8. Open regular file O_DIRECTORY, expect ENOTDIR
> 9. Open hard link file O_RDONLY
> 10. Open hard link file O_WRONLY
> 11. Open hard link file O_RDWR
> 12. Open sym link file O_RDONLY
> 13. Open sym link file O_WRONLY
> 14. Open sym link file O_RDWR
> 15. Open sym link dir O_RDONLY
> 16. Open sym link dir O_WRONLY, expect EISDIR
> 17. Open sym link dir O_RDWR, expect EISDIR
> 18. Open device special file O_RDONLY
> 19. Open device special file O_WRONLY
> 20. Open device special file O_RDWR
> 21. Open non-existing regular file in existing dir
> 22. Open link file O_RDONLY | O_CREAT
> 23. Open symlink file O_RDONLY | O_CREAT
> 24. Open regular file O_RDONLY | O_CREAT
> 25. Open symlink dir O_RDONLY | O_CREAT, expect EISDIR
> 26. Open dir O_RDONLY | O_CREAT, expect EISDIR
> 27. Open regular file O_RDONLY | O_TRUNC, behaviour is undefined but
> should not oops or hang
> 28. Open regular file(non-empty) O_RDONLY | O_TRUNC, behaviour is
> undefined but should not oops or hang
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> v2:
> Remove duplicated open device special test
>
> runtest/ltplite | 1 +
> runtest/stress.part3 | 1 +
> runtest/syscalls | 1 +
> testcases/kernel/syscalls/open/open11.c | 424 ++++++++++++++++++++++++++++++++
> 4 files changed, 427 insertions(+)
> create mode 100644 testcases/kernel/syscalls/open/open11.c
Looks good to me.
Reviewed-by: Caspar Zhang <caspar@casparzhang.com>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-02-04 5:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 10:57 [LTP] [PATCH] syscalls/open11: new open(2) test case Eryu Guan
2013-02-04 1:59 ` Wanlong Gao
2013-02-04 3:22 ` [LTP] [PATCH v2] " Eryu Guan
2013-02-04 3:28 ` Wanlong Gao
2013-02-04 4:55 ` Caspar Zhang [this message]
2013-02-04 5:32 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510F3F46.2010205@casparzhang.com \
--to=caspar@casparzhang.com \
--cc=eguan@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox