Re: [LTP] [PATCH v3 6/7] mm/oom05: new testcase

Wanlong Gao
2013-03-19T03:11:44Z

On 03/18/2013 12:14 PM, Zhouping Liu wrote:
> added a new case to test OOM under the combination
> of MEMCG and CPUSET.
>
> Signed-off-by: Zhouping Liu <zliu@redhat.com>
> ---
> runtest/mm | 1 +
> testcases/kernel/mem/oom/oom05.c | 147 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 148 insertions(+)
> create mode 100644 testcases/kernel/mem/oom/oom05.c
>
> diff --git a/runtest/mm b/runtest/mm
> index a8bd605..56b83f8 100644
> --- a/runtest/mm
> +++ b/runtest/mm
> @@ -77,6 +77,7 @@ oom01 oom01
> oom02 oom02
> oom03 oom03
> oom04 oom04
> +oom05 oom05
>
> swapping01 swapping01 -i 5
>
> diff --git a/testcases/kernel/mem/oom/oom05.c b/testcases/kernel/mem/oom/oom05.c
> new file mode 100644
> index 0000000..0176d42
> --- /dev/null
> +++ b/testcases/kernel/mem/oom/oom05.c
> @@ -0,0 +1,147 @@
> +/*
> + * Out Of Memory (OOM) for MEMCG and CPUSET
> + *
> + * The program is designed to cope with unpredictable like amount and
> + * system physical memory, swap size and other VMM technology like KSM,
> + * memcg, memory hotplug and so on which may affect the OOM
> + * behaviours. It simply increase the memory consumption 3G each time
> + * until all the available memory is consumed and OOM is triggered.
> + *
> + * Copyright (C) 2013 Red Hat, Inc.
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of version 2 of the GNU General Public
> + * License as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it would be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> + *
> + * Further, this software is distributed without any warranty that it
> + * is free of the rightful claim of any third person regarding
> + * infringement or the like. Any license provided herein, whether
> + * implied or otherwise, applies only to this software file. Patent
> + * licenses, if any, provided herein do not apply to combinations of
> + * this program with other software, or any other product whatsoever.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> + * 02110-1301, USA.
> + */
> +
> +#include "config.h"
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +#include <errno.h>
> +#include <fcntl.h>
> +#include <stdio.h>
> +#include "numa_helper.h"
> +#include "test.h"
> +#include "usctest.h"
> +#include "mem.h"
> +
> +char *TCID = "oom05";
> +int TST_TOTAL = 1;
> +
> +#if HAVE_NUMA_H && HAVE_LINUX_MEMPOLICY_H && HAVE_NUMAIF_H \
> + && HAVE_MPOL_CONSTANTS
> +
> +int main(int argc, char *argv[])
> +{
> + char *msg;
> + int lc;
> + int swap_acc_on = 1;
> + char mem[BUFSIZ];
> +
> + msg = parse_opts(argc, argv, NULL, NULL);
> + if (msg != NULL)
> + tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> +
> +#if __WORDSIZE == 32
> + tst_brkm(TCONF, NULL, "test is not designed for 32-bit system.");
> +#endif
> +
> + setup();
> +
> + for (lc = 0; TEST_LOOPING(lc); lc++) {
> + tst_count = 0;
> +
> + tst_resm(TINFO, "OOM on CPUSET & MEMCG...");
> + testoom(0, 0);
> +
> + /*
> + * Under NUMA system, the migration of cpuset's memory
> + * is in charge of cpuset.memory_migrate, we can write

This line has a space before tab warning.
If you should respin the patchset, please fix it, otherwise I can
fix it by hand when applying the patch.

Thanks,
Wanlong Gao

> + * 1 to cpuset.memory_migrate to enable the migration.
> + */
> + if (is_numa(cleanup)) {
> + write_cpuset_files(CPATH_NEW, "memory_migrate", "1");
> + tst_resm(TINFO, "OOM on CPUSET & MEMCG with "
> + "cpuset.memory_migrate=1");
> + testoom(0, 0);
> + }
> +
> + if (access(MEMCG_SW_LIMIT, F_OK) == -1) {
> + if (errno == ENOENT) {
> + tst_resm(TCONF,
> + "memcg swap accounting is disabled");
> + swap_acc_on = 0;
> + } else
> + tst_brkm(TBROK|TERRNO, cleanup, "access");
> + }
> +
> + if (swap_acc_on) {
> + tst_resm(TINFO, "OOM on CPUSET & MEMCG with "
> + "special memswap limitation:");
> + snprintf(mem, BUFSIZ, "%ld", TESTMEM);
> + write_file(MEMCG_SW_LIMIT, mem);
> + testoom(0, 0);
> +
> + tst_resm(TINFO, "OOM on CPUSET & MEMCG with "
> + "disabled memswap limitation:");
> + write_file(MEMCG_SW_LIMIT, "-1");
> + testoom(0, 0);
> + }
> + }
> +
> + cleanup();
> + tst_exit();
> +}
> +
> +void setup(void)
> +{
> + tst_require_root(NULL);
> + tst_sig(FORK, DEF_HANDLER, cleanup);
> + TEST_PAUSE;
> +
> + mount_mem("memcg", "cgroup", "memory", MEMCG_PATH, MEMCG_PATH_NEW);
> + mount_mem("cpuset", "cpuset", NULL, CPATH, CPATH_NEW);
> + write_memcg();
> +
> + set_sys_tune("overcommit_memory", 1, 1);
> +
> + if (is_numa(cleanup))
> + /* For NUMA system, using the first node for cpuset.mems */
> + write_cpusets(get_a_numa_node(cleanup));
> + else
> + /* For nonNUMA system, using node0 for cpuset.mems */
> + write_cpusets(0);
> +
> + overcommit = get_sys_tune("overcommit_memory");
> +}
> +
> +void cleanup(void)
> +{
> + set_sys_tune("overcommit_memory", overcommit, 0);
> + umount_mem(CPATH, CPATH_NEW);
> + umount_mem(MEMCG_PATH, MEMCG_PATH_NEW);
> +
> + TEST_CLEANUP;
> +}
> +
> +#else /* no NUMA */
> +int main(void)
> +{
> + tst_brkm(TCONF, NULL, "no NUMA development packages installed.");
> +}
> +#endif
>