[LTP] [PATCH] pan: fix potential overrun in tag_report

[LTP] [PATCH] pan: fix potential overrun in tag_report

[Jan Stancek]

  char *cuts_info[5];
  ...
  while (tok_num < 5 &&
      (cuts_info[++tok_num] = strtok(NULL, "\t ")) != NULL) ;

While above can run for tok_num == 4, in which case:
  cuts_info[++tok_num] becomes cuts_info[5]
and that is outside of cuts_info array.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 pan/tag_report.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pan/tag_report.c b/pan/tag_report.c
index 473bed1..61caabd 100644
--- a/pan/tag_report.c
+++ b/pan/tag_report.c
@@ -425,7 +425,7 @@ SYM tags;
 int cuts_testcase(tag, keys)
 SYM tag, keys;
 {
-	char *cuts_info[5];
+	char *cuts_info[6];
 	char key[KEYSIZE];
 	char *oldresult, *newresult, *worst_case();
 	int tok_num = 0;
-- 
1.7.1


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] pan: fix potential overrun in tag_report

[Wanlong Gao]

On 03/21/2013 11:08 PM, Jan Stancek wrote:
>   char *cuts_info[5];
>   ...
>   while (tok_num < 5 &&
>       (cuts_info[++tok_num] = strtok(NULL, "\t ")) != NULL) ;
> 
> While above can run for tok_num == 4, in which case:
>   cuts_info[++tok_num] becomes cuts_info[5]
> and that is outside of cuts_info array.
> 
> Signed-off-by: Jan Stancek <jstancek@redhat.com>


Applied, thank you.

Wanlong Gao


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list