Re: [LTP] [PATCH v3 0/3] mm/thp: add two new case

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 04/15/2013 05:26 PM, Zhouping Liu wrote:
> On 04/15/2013 03:46 PM, Wanlong Gao wrote:
>> Hi Zhouping:
>>> The patchset is desinged to test THP functionality.
>>>
>>> when one process allocate hugepage aligned anonymouse pages,
>>> kernel thread 'khugepaged' controlled by sysfs knobs
>>> /sys/kernel/mm/transparent_hugepage/* will scan them, and make
>>> them as transparent hugepage if they are suited, you can find out
>>> how many transparent hugepages are there in one process from
>>> /proc/<pid>/smaps, among the file contents, 'AnonHugePages' entry
>>> stand for transparent hugepage.
>>>
>>> V1 to V2:
>>> accepted Wanlong's suggestion, added some comment for '10s'
>>> added 'static' key word for single-file-only variant.
>>>
>>> V2 to V3:
>>> added some comments for low memory system.
>> I just see that on the kernel before v2.6.39, the "defrag"
>> interface is "[yes] no" or "yes [no]"(eg. RHEL6). While it's changed
>> to boolean after commit e27e6151b154 in v2.6.39-rc4.
> 
> Good catch, I didn't find that.
> 
> I checked the code again, found that khugepaged/defrag is related to defragment,
> and any value of it can't effect the current thp0* cases, so I plan to remove it from
> khugepaged_scan_done() in v4.

Yeah, agree.

Thanks,
Wanlong Gao

> 
> For future cases, which will be related to khugepaged/defrag, we can set the value
> inside setup().
> 
> Thanks,
> Zhouping
> 
>>
>> So, you should deal with the multi-style interface of this "defrag",
>>
>> +        SAFE_FILE_SCANF(cleanup, PATH_KHPD "defrag", "%ld", &defrag);
>>
>> Thanks,
>> Wanlong Gao
>>
>>> Wanlong, I included you into 'Tested-by' thread, thanks for
>>> your reviewing and testing the patchset.
>>>
>>> Zhouping Liu (3):
>>>    mm/thp: new case thp04.c
>>>    lib/mem: introduce a new function set_global_mempolicy()
>>>    mm/thp: add new case thp05
>>>
>>>   runtest/mm                         |   6 ++
>>>   testcases/kernel/mem/include/mem.h |  12 +++
>>>   testcases/kernel/mem/lib/mem.c     | 203 ++++++++++++++++++++++++++++++++++++-
>>>   testcases/kernel/mem/thp/thp04.c   | 136 +++++++++++++++++++++++++
>>>   testcases/kernel/mem/thp/thp05.c   | 152 +++++++++++++++++++++++++++
>>>   5 files changed, 508 insertions(+), 1 deletion(-)
>>>   create mode 100644 testcases/kernel/mem/thp/thp04.c
>>>   create mode 100644 testcases/kernel/mem/thp/thp05.c
>>>
> 
> 


------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list