* [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution @ 2013-04-05 10:18 Ramesh 2013-04-08 0:58 ` Wanlong Gao 0 siblings, 1 reply; 9+ messages in thread From: Ramesh @ 2013-04-05 10:18 UTC (permalink / raw) To: ltp-list Some of the tests which require a block device for their execution are skipped when runltp is run without any block device being specified on commandline.Most of such tests are from syscalls group and as a work around to make these tests run even when no block device is specified,I have made use of loopback device to create a block device with ext4 filesystem. So,runltp is modified to create a block device and set the values for DEVICE and DEVICE_FS_TYPE accordingly. Following are the skipped tests, ---- inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE mount01 mount01 -D DEVICE -T DEVICE_FS_TYPE mount02 mount02 -D DEVICE -T DEVICE_FS_TYPE mount03 mount03 -D DEVICE -T DEVICE_FS_TYPE mount04 mount04 -D DEVICE -T DEVICE_FS_TYPE umount01 umount01 -D DEVICE -T DEVICE_FS_TYPE umount02 umount02 -D DEVICE -T DEVICE_FS_TYPE umount03 umount03 -D DEVICE -T DEVICE_FS_TYPE ---- Please review the patch and let me know if any more changes are needed. Signed-off-by: Ramesh YR <rameshyr@linux.vnet.ibm.com> --- runltp | 52 +++++++++++++++++++++++++++++++++++++++++++++++----- 1 files changed, 47 insertions(+), 5 deletions(-) diff --git a/runltp b/runltp index 04cc690..d7e3f0d 100755 --- a/runltp +++ b/runltp @@ -681,14 +681,22 @@ main() if [ -n "$DEVICE" ]; then sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests + RC=$? else - echo "remove test cases which require the block device." - echo "You can specify it with option -b" - sed -i "/DEVICE/d" ${TMP}/alltests + create_block + if [ $? -eq 0 ]; then + sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests + RC=$? + else + echo -e "no block device was specified on commandline.\n Block device could not be created using loopback device" + echo -e "Tests which require block device are disabled.\n You can specify it with option -b" + sed -i "/DEVICE/d" ${TMP}/alltests + RC=$? + fi fi - if [ $? -ne 0 ]; then - echo "FATAL: error during prcessing alltests file by sed" + if [ $RC -ne 0 ]; then + echo "FATAL: error during processing alltests file by sed" exit 1 fi @@ -971,8 +979,42 @@ main() exit $VALUE } +create_block() +{ + #create a block device with ext4 filesystem. + dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240 &>/dev/null + if [ $? -ne 0 ]; then + echo "Failed to create loopback device image,please check disk space and re-run" + return 1 + else + ##search for an unused loop dev + LOOP_DEV=$(losetup -f) + if [ $? -ne 0 ]; then + echo "no unused loop device is found" + return 1 + else + ##attach the created file to loop dev. + losetup $LOOP_DEV ${TMP}/test.img &>/dev/null + if [ $? -ne 0 ]; then + echo "losetup failed to create block device" + return 1 + else + mkfs.ext4 $LOOP_DEV &>/dev/null + [ $? -ne 0 ] && (echo "creating a ext4 block device failed" && return 1) + #set the values in alltests which require block device. + DEVICE=$LOOP_DEV + DEVICE_FS_TYPE="ext4" + return 0 + fi + fi + fi +} + + cleanup() { + [ -e "${TEMP}/test.img" ] && rm -f ${TEMP}/test.img + [ "$LOOP_DEV" ] && losetup -d $LOOP_DEV rm -rf ${TMP} } -- Regards, Ramesh ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution 2013-04-05 10:18 [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution Ramesh @ 2013-04-08 0:58 ` Wanlong Gao 2013-04-09 7:01 ` Ramesh 0 siblings, 1 reply; 9+ messages in thread From: Wanlong Gao @ 2013-04-08 0:58 UTC (permalink / raw) To: Ramesh; +Cc: ltp-list On 04/05/2013 06:18 PM, Ramesh wrote: > Some of the tests which require a block device for their execution are > skipped > when runltp is run without any block device being specified on > commandline.Most > of such tests are from syscalls group and as a work around to make these > tests > run even when no block device is specified,I have made use of loopback > device > to create a block device with ext4 filesystem. So,runltp is modified to > create > a block device and set the values for DEVICE and DEVICE_FS_TYPE accordingly. I like this change, but seems that your email client wrapped the lines, please take care of this issue when you respin the patch. Thanks, Wanlong Gao > > Following are the skipped tests, > ---- > inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE > mount01 mount01 -D DEVICE -T DEVICE_FS_TYPE > mount02 mount02 -D DEVICE -T DEVICE_FS_TYPE > mount03 mount03 -D DEVICE -T DEVICE_FS_TYPE > mount04 mount04 -D DEVICE -T DEVICE_FS_TYPE > umount01 umount01 -D DEVICE -T DEVICE_FS_TYPE > umount02 umount02 -D DEVICE -T DEVICE_FS_TYPE > umount03 umount03 -D DEVICE -T DEVICE_FS_TYPE > ---- > > Please review the patch and let me know if any more changes are needed. > > > Signed-off-by: Ramesh YR <rameshyr@linux.vnet.ibm.com> > --- > runltp | 52 +++++++++++++++++++++++++++++++++++++++++++++++----- > 1 files changed, 47 insertions(+), 5 deletions(-) > > diff --git a/runltp b/runltp > index 04cc690..d7e3f0d 100755 > --- a/runltp > +++ b/runltp > @@ -681,14 +681,22 @@ main() > > if [ -n "$DEVICE" ]; then > sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests > + RC=$? > else > - echo "remove test cases which require the block device." > - echo "You can specify it with option -b" > - sed -i "/DEVICE/d" ${TMP}/alltests > + create_block > + if [ $? -eq 0 ]; then > + sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests > + RC=$? > + else > + echo -e "no block device was specified on commandline.\n Block > device could not be created using loopback device" > + echo -e "Tests which require block device are disabled.\n You > can specify it with option -b" > + sed -i "/DEVICE/d" ${TMP}/alltests > + RC=$? > + fi > fi > > - if [ $? -ne 0 ]; then > - echo "FATAL: error during prcessing alltests file by sed" > + if [ $RC -ne 0 ]; then > + echo "FATAL: error during processing alltests file by sed" > exit 1 > fi > > @@ -971,8 +979,42 @@ main() > exit $VALUE > } > > +create_block() > +{ > + #create a block device with ext4 filesystem. > + dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240 &>/dev/null > + if [ $? -ne 0 ]; then > + echo "Failed to create loopback device image,please check disk > space and re-run" > + return 1 > + else > + ##search for an unused loop dev > + LOOP_DEV=$(losetup -f) > + if [ $? -ne 0 ]; then > + echo "no unused loop device is found" > + return 1 > + else > + ##attach the created file to loop dev. > + losetup $LOOP_DEV ${TMP}/test.img &>/dev/null > + if [ $? -ne 0 ]; then > + echo "losetup failed to create block device" > + return 1 > + else > + mkfs.ext4 $LOOP_DEV &>/dev/null > + [ $? -ne 0 ] && (echo "creating a ext4 block device > failed" && return 1) > + #set the values in alltests which require block device. > + DEVICE=$LOOP_DEV > + DEVICE_FS_TYPE="ext4" > + return 0 > + fi > + fi > + fi > +} > + > + > cleanup() > { > + [ -e "${TEMP}/test.img" ] && rm -f ${TEMP}/test.img > + [ "$LOOP_DEV" ] && losetup -d $LOOP_DEV > rm -rf ${TMP} > } > ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution 2013-04-08 0:58 ` Wanlong Gao @ 2013-04-09 7:01 ` Ramesh 2013-04-15 3:16 ` Wanlong Gao 2013-04-16 1:40 ` Wanlong Gao 0 siblings, 2 replies; 9+ messages in thread From: Ramesh @ 2013-04-09 7:01 UTC (permalink / raw) To: gaowanlong; +Cc: ltp-list On 04/08/2013 06:28 AM, Wanlong Gao wrote: > On 04/05/2013 06:18 PM, Ramesh wrote: >> Some of the tests which require a block device for their execution are >> skipped >> when runltp is run without any block device being specified on >> commandline.Most >> of such tests are from syscalls group and as a work around to make these >> tests >> run even when no block device is specified,I have made use of loopback >> device >> to create a block device with ext4 filesystem. So,runltp is modified to >> create >> a block device and set the values for DEVICE and DEVICE_FS_TYPE accordingly. > > I like this change, but seems that your email client wrapped the lines, > please take care of this issue when you respin the patch. > > Thanks, > Wanlong Gao > >> >> Following are the skipped tests, >> ---- >> inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE >> mount01 mount01 -D DEVICE -T DEVICE_FS_TYPE >> mount02 mount02 -D DEVICE -T DEVICE_FS_TYPE >> mount03 mount03 -D DEVICE -T DEVICE_FS_TYPE >> mount04 mount04 -D DEVICE -T DEVICE_FS_TYPE >> umount01 umount01 -D DEVICE -T DEVICE_FS_TYPE >> umount02 umount02 -D DEVICE -T DEVICE_FS_TYPE >> umount03 umount03 -D DEVICE -T DEVICE_FS_TYPE >> ---- >> >> Please review the patch and let me know if any more changes are needed. >> >> >> Signed-off-by: Ramesh YR<rameshyr@linux.vnet.ibm.com> >> --- >> runltp | 52 +++++++++++++++++++++++++++++++++++++++++++++++----- >> 1 files changed, 47 insertions(+), 5 deletions(-) >> >> diff --git a/runltp b/runltp >> index 04cc690..d7e3f0d 100755 >> --- a/runltp >> +++ b/runltp >> @@ -681,14 +681,22 @@ main() >> >> if [ -n "$DEVICE" ]; then >> sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests >> + RC=$? >> else >> - echo "remove test cases which require the block device." >> - echo "You can specify it with option -b" >> - sed -i "/DEVICE/d" ${TMP}/alltests >> + create_block >> + if [ $? -eq 0 ]; then >> + sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests >> + RC=$? >> + else >> + echo -e "no block device was specified on commandline.\n Block >> device could not be created using loopback device" >> + echo -e "Tests which require block device are disabled.\n You >> can specify it with option -b" >> + sed -i "/DEVICE/d" ${TMP}/alltests >> + RC=$? >> + fi >> fi >> >> - if [ $? -ne 0 ]; then >> - echo "FATAL: error during prcessing alltests file by sed" >> + if [ $RC -ne 0 ]; then >> + echo "FATAL: error during processing alltests file by sed" >> exit 1 >> fi >> >> @@ -971,8 +979,42 @@ main() >> exit $VALUE >> } >> >> +create_block() >> +{ >> + #create a block device with ext4 filesystem. >> + dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240&>/dev/null >> + if [ $? -ne 0 ]; then >> + echo "Failed to create loopback device image,please check disk >> space and re-run" >> + return 1 >> + else >> + ##search for an unused loop dev >> + LOOP_DEV=$(losetup -f) >> + if [ $? -ne 0 ]; then >> + echo "no unused loop device is found" >> + return 1 >> + else >> + ##attach the created file to loop dev. >> + losetup $LOOP_DEV ${TMP}/test.img&>/dev/null >> + if [ $? -ne 0 ]; then >> + echo "losetup failed to create block device" >> + return 1 >> + else >> + mkfs.ext4 $LOOP_DEV&>/dev/null >> + [ $? -ne 0 ]&& (echo "creating a ext4 block device >> failed"&& return 1) >> + #set the values in alltests which require block device. >> + DEVICE=$LOOP_DEV >> + DEVICE_FS_TYPE="ext4" >> + return 0 >> + fi >> + fi >> + fi >> +} >> + >> + >> cleanup() >> { >> + [ -e "${TEMP}/test.img" ]&& rm -f ${TEMP}/test.img >> + [ "$LOOP_DEV" ]&& losetup -d $LOOP_DEV >> rm -rf ${TMP} >> } >> > Hi, I have corrected few indentation flaws and I think this patch should be fine to commit. Please let me know if you are still facing any issues in extracting this patch for commit. Signed-off-by: Ramesh YR <rameshyr@linux.vnet.ibm.com> --- runltp | 51 ++++++++++++++++++++++++++++++++++++++++++++++----- 1 files changed, 46 insertions(+), 5 deletions(-) diff --git a/runltp b/runltp index 04cc690..5562b9c 100755 --- a/runltp +++ b/runltp @@ -681,14 +681,22 @@ main() if [ -n "$DEVICE" ]; then sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests + RC=$? else - echo "remove test cases which require the block device." - echo "You can specify it with option -b" - sed -i "/DEVICE/d" ${TMP}/alltests + create_block + if [ $? -eq 0 ]; then + sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests + RC=$? + else + echo -e "no block device was specified on commandline.\n Block device could not be created using loopback device" + echo -e "Tests which require block device are disabled.\n You can specify it with option -b" + sed -i "/DEVICE/d" ${TMP}/alltests + RC=$? + fi fi - if [ $? -ne 0 ]; then - echo "FATAL: error during prcessing alltests file by sed" + if [ $RC -ne 0 ]; then + echo "FATAL: error during processing alltests file by sed" exit 1 fi @@ -971,8 +979,41 @@ main() exit $VALUE } +create_block() +{ + #create a block device with ext4 filesystem. + dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240 &>/dev/null + if [ $? -ne 0 ]; then + echo "Failed to create loopback device image,please check disk space and re-run" + return 1 + else + ##search for an unused loop dev + LOOP_DEV=$(losetup -f) + if [ $? -ne 0 ]; then + echo "no unused loop device is found" + return 1 + else + ##attach the created file to loop dev. + losetup $LOOP_DEV ${TMP}/test.img &>/dev/null + if [ $? -ne 0 ]; then + echo "losetup failed to create block device" + return 1 + else + mkfs.ext4 $LOOP_DEV &>/dev/null + [ $? -ne 0 ] && (echo "creating a ext4 block device failed" && return 1) + #set the values in alltests which require block device. + DEVICE=$LOOP_DEV + DEVICE_FS_TYPE="ext4" + return 0 + fi + fi + fi +} + cleanup() { + [ "$LOOP_DEV" ] && losetup -d $LOOP_DEV + [ -e "${TEMP}/test.img" ] && rm -f ${TEMP}/test.img rm -rf ${TMP} } -- Regards, Ramesh ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution 2013-04-09 7:01 ` Ramesh @ 2013-04-15 3:16 ` Wanlong Gao 2013-04-15 13:24 ` chrubis 2013-04-16 1:40 ` Wanlong Gao 1 sibling, 1 reply; 9+ messages in thread From: Wanlong Gao @ 2013-04-15 3:16 UTC (permalink / raw) To: ltp-list; +Cc: Ramesh On 04/09/2013 03:01 PM, Ramesh wrote: > On 04/08/2013 06:28 AM, Wanlong Gao wrote: >> On 04/05/2013 06:18 PM, Ramesh wrote: >>> Some of the tests which require a block device for their execution are >>> skipped >>> when runltp is run without any block device being specified on >>> commandline.Most >>> of such tests are from syscalls group and as a work around to make these >>> tests >>> run even when no block device is specified,I have made use of loopback >>> device >>> to create a block device with ext4 filesystem. So,runltp is modified to >>> create >>> a block device and set the values for DEVICE and DEVICE_FS_TYPE accordingly. >> >> I like this change, but seems that your email client wrapped the lines, >> please take care of this issue when you respin the patch. >> >> Thanks, >> Wanlong Gao >> >>> >>> Following are the skipped tests, >>> ---- >>> inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE >>> mount01 mount01 -D DEVICE -T DEVICE_FS_TYPE >>> mount02 mount02 -D DEVICE -T DEVICE_FS_TYPE >>> mount03 mount03 -D DEVICE -T DEVICE_FS_TYPE >>> mount04 mount04 -D DEVICE -T DEVICE_FS_TYPE >>> umount01 umount01 -D DEVICE -T DEVICE_FS_TYPE >>> umount02 umount02 -D DEVICE -T DEVICE_FS_TYPE >>> umount03 umount03 -D DEVICE -T DEVICE_FS_TYPE >>> ---- >>> >>> Please review the patch and let me know if any more changes are needed. >>> >>> >>> Signed-off-by: Ramesh YR<rameshyr@linux.vnet.ibm.com> >>> --- >>> runltp | 52 +++++++++++++++++++++++++++++++++++++++++++++++----- >>> 1 files changed, 47 insertions(+), 5 deletions(-) >>> >>> diff --git a/runltp b/runltp >>> index 04cc690..d7e3f0d 100755 >>> --- a/runltp >>> +++ b/runltp >>> @@ -681,14 +681,22 @@ main() >>> >>> if [ -n "$DEVICE" ]; then >>> sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests >>> + RC=$? >>> else >>> - echo "remove test cases which require the block device." >>> - echo "You can specify it with option -b" >>> - sed -i "/DEVICE/d" ${TMP}/alltests >>> + create_block >>> + if [ $? -eq 0 ]; then >>> + sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests >>> + RC=$? >>> + else >>> + echo -e "no block device was specified on commandline.\n Block >>> device could not be created using loopback device" >>> + echo -e "Tests which require block device are disabled.\n You >>> can specify it with option -b" >>> + sed -i "/DEVICE/d" ${TMP}/alltests >>> + RC=$? >>> + fi >>> fi >>> >>> - if [ $? -ne 0 ]; then >>> - echo "FATAL: error during prcessing alltests file by sed" >>> + if [ $RC -ne 0 ]; then >>> + echo "FATAL: error during processing alltests file by sed" >>> exit 1 >>> fi >>> >>> @@ -971,8 +979,42 @@ main() >>> exit $VALUE >>> } >>> >>> +create_block() >>> +{ >>> + #create a block device with ext4 filesystem. >>> + dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240&>/dev/null >>> + if [ $? -ne 0 ]; then >>> + echo "Failed to create loopback device image,please check disk >>> space and re-run" >>> + return 1 >>> + else >>> + ##search for an unused loop dev >>> + LOOP_DEV=$(losetup -f) >>> + if [ $? -ne 0 ]; then >>> + echo "no unused loop device is found" >>> + return 1 >>> + else >>> + ##attach the created file to loop dev. >>> + losetup $LOOP_DEV ${TMP}/test.img&>/dev/null >>> + if [ $? -ne 0 ]; then >>> + echo "losetup failed to create block device" >>> + return 1 >>> + else >>> + mkfs.ext4 $LOOP_DEV&>/dev/null >>> + [ $? -ne 0 ]&& (echo "creating a ext4 block device >>> failed"&& return 1) >>> + #set the values in alltests which require block device. >>> + DEVICE=$LOOP_DEV >>> + DEVICE_FS_TYPE="ext4" >>> + return 0 >>> + fi >>> + fi >>> + fi >>> +} >>> + >>> + >>> cleanup() >>> { >>> + [ -e "${TEMP}/test.img" ]&& rm -f ${TEMP}/test.img >>> + [ "$LOOP_DEV" ]&& losetup -d $LOOP_DEV >>> rm -rf ${TMP} >>> } >>> >> > Hi, > > I have corrected few indentation flaws and I think this patch should be fine to commit. > Please let me know if you are still facing any issues in extracting this patch for commit. > > > Signed-off-by: Ramesh YR <rameshyr@linux.vnet.ibm.com> Acked-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> Any other objections? Thanks, Wanlong Gao > --- > runltp | 51 ++++++++++++++++++++++++++++++++++++++++++++++----- > 1 files changed, 46 insertions(+), 5 deletions(-) > > diff --git a/runltp b/runltp > index 04cc690..5562b9c 100755 > --- a/runltp > +++ b/runltp > @@ -681,14 +681,22 @@ main() > > if [ -n "$DEVICE" ]; then > sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests > + RC=$? > else > - echo "remove test cases which require the block device." > - echo "You can specify it with option -b" > - sed -i "/DEVICE/d" ${TMP}/alltests > + create_block > + if [ $? -eq 0 ]; then > + sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests > + RC=$? > + else > + echo -e "no block device was specified on commandline.\n Block device could not be created using loopback device" > + echo -e "Tests which require block device are disabled.\n You can specify it with option -b" > + sed -i "/DEVICE/d" ${TMP}/alltests > + RC=$? > + fi > fi > > - if [ $? -ne 0 ]; then > - echo "FATAL: error during prcessing alltests file by sed" > + if [ $RC -ne 0 ]; then > + echo "FATAL: error during processing alltests file by sed" > exit 1 > fi > > @@ -971,8 +979,41 @@ main() > exit $VALUE > } > > +create_block() > +{ > + #create a block device with ext4 filesystem. > + dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240 &>/dev/null > + if [ $? -ne 0 ]; then > + echo "Failed to create loopback device image,please check disk space and re-run" > + return 1 > + else > + ##search for an unused loop dev > + LOOP_DEV=$(losetup -f) > + if [ $? -ne 0 ]; then > + echo "no unused loop device is found" > + return 1 > + else > + ##attach the created file to loop dev. > + losetup $LOOP_DEV ${TMP}/test.img &>/dev/null > + if [ $? -ne 0 ]; then > + echo "losetup failed to create block device" > + return 1 > + else > + mkfs.ext4 $LOOP_DEV &>/dev/null > + [ $? -ne 0 ] && (echo "creating a ext4 block device failed" && return 1) > + #set the values in alltests which require block device. > + DEVICE=$LOOP_DEV > + DEVICE_FS_TYPE="ext4" > + return 0 > + fi > + fi > + fi > +} > + > cleanup() > { > + [ "$LOOP_DEV" ] && losetup -d $LOOP_DEV > + [ -e "${TEMP}/test.img" ] && rm -f ${TEMP}/test.img > rm -rf ${TMP} > } > ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution 2013-04-15 3:16 ` Wanlong Gao @ 2013-04-15 13:24 ` chrubis 0 siblings, 0 replies; 9+ messages in thread From: chrubis @ 2013-04-15 13:24 UTC (permalink / raw) To: Wanlong Gao; +Cc: ltp-list, Ramesh Hi! > > Signed-off-by: Ramesh YR <rameshyr@linux.vnet.ibm.com> > > Acked-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> > > > Any other objections? The patch logic looks fine. The only thing that doesn't look 100% right are the overly long lines (which could be fixed by splitting the messages and print each sentence with it's own echo). -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution 2013-04-09 7:01 ` Ramesh 2013-04-15 3:16 ` Wanlong Gao @ 2013-04-16 1:40 ` Wanlong Gao 2013-04-22 8:44 ` Ramesh 1 sibling, 1 reply; 9+ messages in thread From: Wanlong Gao @ 2013-04-16 1:40 UTC (permalink / raw) To: Ramesh; +Cc: ltp-list On 04/09/2013 03:01 PM, Ramesh wrote: > Hi, > > I have corrected few indentation flaws and I think this patch should be fine to commit. > Please let me know if you are still facing any issues in extracting this patch for commit. > > > Signed-off-by: Ramesh YR <rameshyr@linux.vnet.ibm.com> Applied with the long-line-echo fixed, thank you. Wanlong Gao ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution 2013-04-16 1:40 ` Wanlong Gao @ 2013-04-22 8:44 ` Ramesh 2013-04-22 9:05 ` Wanlong Gao 2013-04-22 10:01 ` chrubis 0 siblings, 2 replies; 9+ messages in thread From: Ramesh @ 2013-04-22 8:44 UTC (permalink / raw) To: gaowanlong, ltp-list On 04/16/2013 07:10 AM, Wanlong Gao wrote: > On 04/09/2013 03:01 PM, Ramesh wrote: >> Hi, >> >> I have corrected few indentation flaws and I think this patch should be fine to commit. >> Please let me know if you are still facing any issues in extracting this patch for commit. >> >> >> Signed-off-by: Ramesh YR<rameshyr@linux.vnet.ibm.com> > Applied with the long-line-echo fixed, thank you. > > > Wanlong Gao > Thanks Wanlong ! I think History part in runltp script needs to be updated to reflect the changes. Regards, Ramesh ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution 2013-04-22 8:44 ` Ramesh @ 2013-04-22 9:05 ` Wanlong Gao 2013-04-22 10:01 ` chrubis 1 sibling, 0 replies; 9+ messages in thread From: Wanlong Gao @ 2013-04-22 9:05 UTC (permalink / raw) To: Ramesh; +Cc: ltp-list On 04/22/2013 04:44 PM, Ramesh wrote: > On 04/16/2013 07:10 AM, Wanlong Gao wrote: >> On 04/09/2013 03:01 PM, Ramesh wrote: >>> Hi, >>> >>> I have corrected few indentation flaws and I think this patch should be fine to commit. >>> Please let me know if you are still facing any issues in extracting this patch for commit. >>> >>> >>> Signed-off-by: Ramesh YR<rameshyr@linux.vnet.ibm.com> >> Applied with the long-line-echo fixed, thank you. >> >> >> Wanlong Gao >> > Thanks Wanlong ! > > I think History part in runltp script needs to be updated to reflect the changes. Patches are welcome! ;) Thanks, Wanlong Gao > > > Regards, > Ramesh > > ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution 2013-04-22 8:44 ` Ramesh 2013-04-22 9:05 ` Wanlong Gao @ 2013-04-22 10:01 ` chrubis 1 sibling, 0 replies; 9+ messages in thread From: chrubis @ 2013-04-22 10:01 UTC (permalink / raw) To: Ramesh; +Cc: ltp-list Hi! > I think History part in runltp script needs to be updated to reflect the > changes. Since we started to use git and make sure the commit messages describe the change well the "History" stored in the files are not that relevant anymore. If there is history that could not be found by 'git log filename' it is kept. For new changes is updating the "History" is not recomended. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-04-22 10:01 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-04-05 10:18 [LTP] [PATCH] runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution Ramesh 2013-04-08 0:58 ` Wanlong Gao 2013-04-09 7:01 ` Ramesh 2013-04-15 3:16 ` Wanlong Gao 2013-04-15 13:24 ` chrubis 2013-04-16 1:40 ` Wanlong Gao 2013-04-22 8:44 ` Ramesh 2013-04-22 9:05 ` Wanlong Gao 2013-04-22 10:01 ` chrubis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox