public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: DAN LI <li.dan@cn.fujitsu.com>
To: LTP list <ltp-list@lists.sourceforge.net>
Subject: [LTP] [PATCH 2/2] syscalls/mount/mount02.c: modify array "exp_enos"
Date: Fri, 26 Apr 2013 15:53:38 +0800	[thread overview]
Message-ID: <517A3282.2050809@cn.fujitsu.com> (raw)
In-Reply-To: <517A31DE.2050003@cn.fujitsu.com>

Expected errno setted in array "exp_enos" do not match
echo test item rightly, leading to two problems:

* Not every test item in mount02 is executed.
     There are 13 test items in mount02 currently to test error:
     ENODEV, ENOTBLK, EBUSY, EBUSY, EINVAL, EINVAL, EINVAL, EFAULT,
     EFAULT, ENAMETOOLONG, ENOENT, ENOENT, ENOTDIR

     But, only 8 of them are tested as specified in array "exp_enos":
     ENODEV, ENOTBLK, EBUSY, EINVAL, EFAULT, ENAMETOOLONG,
     ENOENT, ENOTDIR

* For test item which is executed, its errno returned is maybe not
the one expected.

This patch modifies array "exp_enos" to make it one-to-one correspondent
with echo test item, to fix above problems.

Signed-off-by: DAN LI <li.dan@cn.fujitsu.com>
---
 testcases/kernel/syscalls/mount/mount02.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/mount/mount02.c b/testcases/kernel/syscalls/mount/mount02.c
index 8dcf8de..95796f2 100644
--- a/testcases/kernel/syscalls/mount/mount02.c
+++ b/testcases/kernel/syscalls/mount/mount02.c
@@ -81,8 +81,10 @@ static char *device;
 static int Tflag;
 static int Dflag;

-static int exp_enos[] = { ENODEV, ENOTBLK, EBUSY, EINVAL, EFAULT, ENAMETOOLONG,
-	ENOENT, ENOTDIR, 0
+static int exp_enos[] = {
+	ENODEV, ENOTBLK, EBUSY, EBUSY, EINVAL,
+	EINVAL, EINVAL, EFAULT, EFAULT, ENAMETOOLONG,
+	ENOENT, ENOENT, ENOTDIR, 0
 };

 int TST_TOTAL = (sizeof(exp_enos) / sizeof(exp_enos[0])) - 1;
-- 
1.8.1

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2013-04-26  7:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26  7:50 [LTP] [PATCH 1/2] syscalls/mount/mount02.c: cleanup DAN LI
2013-04-26  7:53 ` DAN LI [this message]
2013-04-27  6:07   ` [LTP] [PATCH 2/2] syscalls/mount/mount02.c: modify array "exp_enos" Mike Frysinger
2013-05-06  9:16   ` Wanlong Gao
2013-04-27  6:05 ` [LTP] [PATCH 1/2] syscalls/mount/mount02.c: cleanup Mike Frysinger
2013-05-06  9:15 ` Wanlong Gao
  -- strict thread matches above, loose matches on Subject: below --
2013-04-26 16:38 [LTP] [PATCH 2/2] syscalls/mount/mount02.c: modify array "exp_enos" DAN LI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517A3282.2050809@cn.fujitsu.com \
    --to=li.dan@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox