[LTP] [PATCH 2/2] syscalls/mount/mount02.c: modify array "exp_enos"

[LTP] [PATCH 2/2] syscalls/mount/mount02.c: modify array "exp_enos"

[DAN LI]

Expected errno setted in array "exp_enos" do not match
echo test item rightly, leading to two problems:

* Not every test item in mount02 is executed.
     There are 13 test items in mount02 currently to test error:
     ENODEV, ENOTBLK, EBUSY, EBUSY, EINVAL, EINVAL, EINVAL, EFAULT,
     EFAULT, ENAMETOOLONG, ENOENT, ENOENT, ENOTDIR

     But, only 8 of them are tested as specified in array "exp_enos":
     ENODEV, ENOTBLK, EBUSY, EINVAL, EFAULT, ENAMETOOLONG,
     ENOENT, ENOTDIR

* For test item which is executed, its errno returned is maybe not
the one expected.

This patch modifies array "exp_enos" to make it one-to-one correspondent
with echo test item, to fix above problems.

Signed-off-by: DAN LI <li.dan@cn.fujitsu.com>
---
 testcases/kernel/syscalls/mount/mount02.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/mount/mount02.c b/testcases/kernel/syscalls/mount/mount02.c
index 8dcf8de..95796f2 100644
--- a/testcases/kernel/syscalls/mount/mount02.c
+++ b/testcases/kernel/syscalls/mount/mount02.c
@@ -81,8 +81,10 @@ static char *device;
 static int Tflag;
 static int Dflag;

-static int exp_enos[] = { ENODEV, ENOTBLK, EBUSY, EINVAL, EFAULT, ENAMETOOLONG,
-	ENOENT, ENOTDIR, 0
+static int exp_enos[] = {
+	ENODEV, ENOTBLK, EBUSY, EBUSY, EINVAL,
+	EINVAL, EINVAL, EFAULT, EFAULT, ENAMETOOLONG,
+	ENOENT, ENOENT, ENOTDIR, 0
 };

 int TST_TOTAL = (sizeof(exp_enos) / sizeof(exp_enos[0])) - 1;
-- 
1.8.1

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] syscalls/mount/mount02.c: modify array "exp_enos"

[DAN LI]

> >Expected errno setted in array "exp_enos" do not match
> >echo test item rightly, leading to two problems:
>
>what is "echo test item" ?

Sorry for this type error confused you ...

s/echo/each

Thanks,
DAN LI

>-mike


------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] syscalls/mount/mount02.c: modify array "exp_enos"

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 189 bytes --]

On Friday 26 April 2013 03:53:38 DAN LI wrote:
> Expected errno setted in array "exp_enos" do not match
> echo test item rightly, leading to two problems:

what is "echo test item" ?
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 421 bytes --]

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] syscalls/mount/mount02.c: modify array "exp_enos"

[Wanlong Gao]

On 04/26/2013 03:53 PM, DAN LI wrote:
> Expected errno setted in array "exp_enos" do not match
> echo test item rightly, leading to two problems:
> 
> * Not every test item in mount02 is executed.
>      There are 13 test items in mount02 currently to test error:
>      ENODEV, ENOTBLK, EBUSY, EBUSY, EINVAL, EINVAL, EINVAL, EFAULT,
>      EFAULT, ENAMETOOLONG, ENOENT, ENOENT, ENOTDIR
> 
>      But, only 8 of them are tested as specified in array "exp_enos":
>      ENODEV, ENOTBLK, EBUSY, EINVAL, EFAULT, ENAMETOOLONG,
>      ENOENT, ENOTDIR
> 
> * For test item which is executed, its errno returned is maybe not
> the one expected.
> 
> This patch modifies array "exp_enos" to make it one-to-one correspondent
> with echo test item, to fix above problems.
> 
> Signed-off-by: DAN LI <li.dan@cn.fujitsu.com>

Applied with s/echo/each/, thanks for you and Mike.

Wanlong Gao


------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list