From: DAN LI <li.dan@cn.fujitsu.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 1/2]semctl/semctl01.c: cleanup
Date: Fri, 10 May 2013 10:35:15 +0800 [thread overview]
Message-ID: <518C5CE3.9070702@cn.fujitsu.com> (raw)
In-Reply-To: <201305091222.52821.vapier@gentoo.org>
On 05/10/2013 12:22 AM, Mike Frysinger wrote:
> On Thursday 09 May 2013 04:42:55 DAN LI wrote:
>> --- a/testcases/kernel/syscalls/ipc/semctl/semctl01.c
>> +++ b/testcases/kernel/syscalls/ipc/semctl/semctl01.c
>>
>> /*
>> @@ -24,32 +23,6 @@
>> * DESCRIPTION
>> * semctl01 - test the 10 possible semctl() commands
>> *
>> - * ALGORITHM
>> - * create a semaphore set with read and alter permissions
>> - * loop if that option was specified
>> - * loop through the test cases
>> - * do any setup required for the test case
>> - * make the semctl() call using the TEST() macro
>> - * check the return code
>> - * if failure, issue a FAIL message.
>> - * otherwise,
>> - * if doing functionality testing
>> - * call the appropriate test function
>> - * if correct,
>> - * issue a PASS message
>> - * otherwise
>> - * issue a FAIL message
>> - * call cleanup
>
> i don't see high level DESCRIPTION/ALGORITHM as "useless". why do you ?
In my opinion, "ALGORITHM" section of many ltp testcases follows one format:
------------------------------------------------
setup()
loop test frame
loop all test cases
TEST(call)
if call failed
log the errno
else
if functionality is ok
case PASS
else
case FAIL
cleanup()
------------------------------------------------
So, i think this section is redundant and useless once someone has
learned the test frame.
>
>> * HISTORY
>
> on the flip side, HISTORY is pretty useless. that's what `git log` is for.
Agreed.
I'll send a V2 to fix it.
Thanks,
DAN LI
> -mike
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-05-10 2:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 8:42 [LTP] [PATCH 1/2]semctl/semctl01.c: cleanup DAN LI
2013-05-09 8:46 ` [LTP] [PATCH 2/2]semctl/semctl01.c: Test features IPC_INFO, SEM_INFO and SEM_STAT DAN LI
2013-05-09 13:32 ` chrubis
[not found] ` <201305091220.44861.vapier@gentoo.org>
2013-05-10 8:30 ` Wanlong Gao
2013-05-10 15:36 ` Mike Frysinger
2013-05-13 2:28 ` Wanlong Gao
2013-05-09 16:22 ` [LTP] [PATCH 1/2]semctl/semctl01.c: cleanup Mike Frysinger
2013-05-10 2:35 ` DAN LI [this message]
2013-05-10 15:27 ` Mike Frysinger
2013-05-13 11:23 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518C5CE3.9070702@cn.fujitsu.com \
--to=li.dan@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox