From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UbiVb-0002Mr-GW for ltp-list@lists.sourceforge.net; Mon, 13 May 2013 02:29:03 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UbiVa-00063a-1w for ltp-list@lists.sourceforge.net; Mon, 13 May 2013 02:29:03 +0000 Message-ID: <51904FC9.3060907@cn.fujitsu.com> Date: Mon, 13 May 2013 10:28:25 +0800 From: Wanlong Gao MIME-Version: 1.0 References: <518B618F.80400@cn.fujitsu.com> <201305091220.44861.vapier@gentoo.org> <518CB008.5080402@cn.fujitsu.com> <201305101136.02884.vapier@gentoo.org> In-Reply-To: <201305101136.02884.vapier@gentoo.org> Subject: Re: [LTP] [PATCH 2/2]semctl/semctl01.c: Test features IPC_INFO, SEM_INFO and SEM_STAT Reply-To: gaowanlong@cn.fujitsu.com List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Mike Frysinger Cc: ltp-list@lists.sourceforge.net On 05/10/2013 11:36 PM, Mike Frysinger wrote: > On Friday 10 May 2013 04:30:00 Wanlong Gao wrote: >> On 05/10/2013 12:20 AM, Mike Frysinger wrote: >>> On Thursday 09 May 2013 09:32:32 chrubis@suse.cz wrote: >>>>> +#ifdef __linux__ >>>>> +int TST_TOTAL = 13; >>>>> +#else >>>>> >>>>> int TST_TOTAL = 10; >>>>> >>>>> +#endif >>>>> >>>>> static int sem_id_1 = -1; >>>>> >>>>> @@ -57,8 +65,14 @@ static void func_sval(void); >>>>> >>>>> static void func_rmid(void); >>>>> static void child_cnt(void); >>>>> static void child_pid(void); >>>>> >>>>> +#ifdef __linux__ >>>>> +static void func_iinfo(int); >>>>> +static void func_sinfo(void); >>>>> +static void func_sstat(int); >>>>> +#endif >>>> >>>> Well the only part of the LTP that we promise that will build and run on >>>> anything else than Linux is Open Posix Testsuite, so in my opinion these >>>> ifdefs are not needed. Has anybody different opinion? >>> >>> i agree -- drop the __linux__ check, especially under testcases/kernel/ >>> ... the "kernel" there is "linux". >> >> So, you mean drop the "sgi" as well? > > scrubbing it from testcases/kernel/syscalls/sighold/sighold02.c makes sense. > SGI is dead and so is IRIX. if they want to run tests against their system, > then can download an older version of LTP. Make sense. Thanks, Wanlong Gao > -mike > ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list