Re: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg

[DAN LI <li.dan@cn.fujitsu.com>]

On 05/29/2013 06:44 PM, Jan Stancek wrote:
> 
> ----- Original Message -----
>> From: "DAN LI" <li.dan@cn.fujitsu.com>
>> To: "Jan Stancek" <jstancek@redhat.com>
>> Cc: "LTP list" <ltp-list@lists.sourceforge.net>
>> Sent: Wednesday, 29 May, 2013 12:25:45 PM
>> Subject: Re: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg
>>
>> On 05/29/2013 05:18 PM, Jan Stancek wrote:
>>>
>>> ----- Original Message -----
>>>> From: "DAN LI" <li.dan@cn.fujitsu.com>
>>>> To: "LTP list" <ltp-list@lists.sourceforge.net>
>>>> Sent: Wednesday, 29 May, 2013 10:58:47 AM
>>>> Subject: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE
>>>> to shmflg
>>>>
>>>>
>>>> 1. Remove useless comments
>>>>
>>>> 2. Revise code to follow ltp-code-style
>>>>
>>>> 3. Add SHM_NORESERVE to shmflg to test
>>>
>>> Can you add some description why you are adding this flag?
>>
>> Actually, we are trying to complete test cases and expand
>> the test scope of LTP.
>>
>> So, it is just for completeness of this case.
> 
> My concern here is:
> So if we add this flag, we cover SHM_NORESERVE path.
> Do we have a testcase which still covers current non-SHM_NORESERVE path?

Hi Jan,

Sorry for the late reply. :)

In my opinion, SHM_NORESERVE is an independent feature of others and should have
no effect on them, so we do not need a non-SHM_NORESERVE path.
They are like two branches of a river, one branch can do nothing on the other one,
but if either of them goes wrong, the river will get feedback.

And maybe, it's just what the author of this case considered since he tested
SHM_RW(S_IRUSR | S_IWUSR) together with IPC_CREAT | IPC_EXCL.


Regards,
DAN LI

> 
> Regards,
> Jan
> 

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list