From: DAN LI <li.dan@cn.fujitsu.com>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg
Date: Fri, 31 May 2013 15:25:22 +0800 [thread overview]
Message-ID: <51A85062.7080406@cn.fujitsu.com> (raw)
In-Reply-To: <51A5E61E.7000405@casparzhang.com>
On 05/29/2013 07:27 PM, Caspar Zhang wrote:
> On 05/29/2013 06:25 PM, DAN LI wrote:
>> On 05/29/2013 05:18 PM, Jan Stancek wrote:
>>>
>>> ----- Original Message -----
>>>> From: "DAN LI" <li.dan@cn.fujitsu.com>
>>>> To: "LTP list" <ltp-list@lists.sourceforge.net>
>>>> Sent: Wednesday, 29 May, 2013 10:58:47 AM
>>>> Subject: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg
>>>>
>>>>
>>>> 1. Remove useless comments
>>>>
>>>> 2. Revise code to follow ltp-code-style
>>>>
>>>> 3. Add SHM_NORESERVE to shmflg to test
>>>
>>> Can you add some description why you are adding this flag?
>>
>> Actually, we are trying to complete test cases and expand
>> the test scope of LTP.
>>
>> So, it is just for completeness of this case.
>
> Would it be better to split the code-style fix and the functional/feature part?
Agree.
Coming V2 will make it.
Regards,
DAN LI
>
> Caspar
>
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-05-31 7:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 8:58 [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg DAN LI
2013-05-29 9:18 ` Jan Stancek
2013-05-29 10:25 ` DAN LI
2013-05-29 10:44 ` Jan Stancek
2013-05-31 7:20 ` DAN LI
2013-06-03 20:47 ` Jan Stancek
2013-06-04 7:30 ` Caspar Zhang
2013-06-04 9:46 ` DAN LI
2013-05-29 11:27 ` Caspar Zhang
2013-05-31 7:25 ` DAN LI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A85062.7080406@cn.fujitsu.com \
--to=li.dan@cn.fujitsu.com \
--cc=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox