Re: [LTP] [PATCH v4] fw_load: new test of device firmware loading

[alexey.kodanev@oracle.com]

Hi!

On 06/20/2013 05:29 PM, Jan Stancek wrote:
>
> Hi,
>
> looks good to me. I ran it with 3.10-rc4 and 2.6.18 kernel, worked as expected.
> This included:
> [PATCH v3] configure: add configure checks to compile kernel modules
> [PATCH] tst_module: create new library functions for kernel modules
> [PATCH v4] fw_load: new test of device firmware loading
>
> I have one small suggestion, likely not worthy of making v5 just for this.
> We could apply it on top later:
>
> --- testcases/kernel/firmware/fw_load_kernel/Makefile	2013-06-20 15:08:19.339046672 +0200
> +++ /tmp/Makefile	2013-06-20 15:11:50.876602284 +0200
> @@ -18,7 +18,9 @@
>
>   ifneq ($(KERNELRELEASE),)
>
> +ifdef CONFIG_FW_LOADER
>   obj-m		:= $(MODULE).o
> +endif
>
I see, firmware loading/release functions works only with this config.
>   else
>
> @@ -26,7 +28,7 @@
>   include $(top_srcdir)/include/mk/env_pre.mk
>
>   MAKE_TARGETS	:= $(MODULE).ko
> -$(MODULE).ko:
> +$(MODULE).ko: fw_load.c
>   	-$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir)
>   	-mv $(MODULE).ko $(MODULE).ko~
>   	-$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir) clean
>
OK

Thanks,
Alexey

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list