Re: [LTP] [PATCH] clock_settime03: don't test PROCESS_CPUTIME_ID and THREAD_CPUTIME_ID

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 06/27/2013 05:39 PM, Jan Stancek wrote:
> 
> 
> 
> 
> ----- Original Message -----
>> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
>> To: "LTP" <ltp-list@lists.sourceforge.net>
>> Cc: "Cyril Hrubis" <chrubis@suse.cz>, "Caspar Zhang" <caspar@casparzhang.com>, "Garrett Cooper" <yanegomi@gmail.com>,
>> "Mike Frysinger" <vapier@gentoo.org>, jstancek@redhat.com, "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
>> Sent: Thursday, 27 June, 2013 5:43:09 AM
>> Subject: [PATCH] clock_settime03: don't test PROCESS_CPUTIME_ID and THREAD_CPUTIME_ID
>>
>> PROCESS_CPUTIME_ID and THREAD_CPUTIME_ID are not supported before
>> kernel 2.6.12, and changed back since 2.6.38. And they are
>> thought improper supported on Linux, so we just remove them
>> from the test of clock_settime and remain them be untested.
> 
> Hi,
> 
> Isn't this test testing that these are not supported?
>   EINVAL The clk_id specified is not supported on this system.
> 
> Are these going to be removed completely?
> What is the risk if we keep them?

The problem is what Cyril said in this thread.

Thanks,
Wanlong Gao

> 
> Regards,
> Jan
> 
>>
>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>> ---
>>  testcases/kernel/timers/clock_settime/clock_settime03.c | 15 ---------------
>>  1 file changed, 15 deletions(-)
>>
>> diff --git a/testcases/kernel/timers/clock_settime/clock_settime03.c
>> b/testcases/kernel/timers/clock_settime/clock_settime03.c
>> index a949303..3693395 100644
>> --- a/testcases/kernel/timers/clock_settime/clock_settime03.c
>> +++ b/testcases/kernel/timers/clock_settime/clock_settime03.c
>> @@ -37,8 +37,6 @@ clockid_t clocks[] = {
>>  	CLOCK_REALTIME,
>>  	CLOCK_REALTIME,
>>  	CLOCK_REALTIME,
>> -	CLOCK_PROCESS_CPUTIME_ID,
>> -	CLOCK_THREAD_CPUTIME_ID
>>  };
>>  
>>  int testcases[] = {
>> @@ -49,8 +47,6 @@ int testcases[] = {
>>  	EINVAL,			/* Invalid timespec     */
>>  	EINVAL,			/* NSEC_PER_SEC + 1     */
>>  	EPERM,			/* non-root user        */
>> -	0,
>> -	0,
>>  };
>>  
>>  char *TCID = "clock_settime03";
>> @@ -70,17 +66,6 @@ int main(int ac, char **av)
>>  	if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
>>  		tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
>>  
>> -	/* PROCESS_CPUTIME_ID & THREAD_CPUTIME_ID are not supported on
>> -	 * kernel versions lower than 2.6.12 and changed back in 2.6.38
>> -	 */
>> -	if ((tst_kvercmp(2, 6, 12)) < 0 || (tst_kvercmp(2, 6, 38)) >= 0) {
>> -		testcases[7] = EINVAL;
>> -		testcases[8] = EINVAL;
>> -	} else {
>> -		testcases[7] = EFAULT;
>> -		testcases[8] = EFAULT;
>> -	}
>> -
>>  	setup();
>>  
>>  	for (lc = 0; TEST_LOOPING(lc); lc++) {
>> --
>> 1.8.3.1.448.gfb7dfaa
>>
>>
> 


------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list