From: alexey.kodanev@oracle.com
To: Mike Frysinger <vapier@gentoo.org>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v4] lib: tst_module: add library functions for kernel modules
Date: Mon, 01 Jul 2013 12:30:48 +0400 [thread overview]
Message-ID: <51D13E38.5010309@oracle.com> (raw)
In-Reply-To: <201306280135.45066.vapier@gentoo.org>
On 06/28/2013 09:35 AM, Mike Frysinger wrote:
> On Thursday 27 June 2013 11:09:22 Alexey Kodanev wrote:
> \> +void tst_module_load(void (cleanup_fn)(void),
>> + const char *mod_name, char *const argv[])
>> +{
>> + char *mod_path = NULL;
>> + tst_module_exists(cleanup_fn, mod_name,&mod_path);
>> +
>> + static int offset = 2; /* command name& module path */
> why static ? i would use const instead.
> -mike
Yes, const must be used here, and static is not needed for an int. I
will fix it.
Thanks,
Alexey
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-07-01 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 15:09 [LTP] [PATCH v4] lib: tst_module: add library functions for kernel modules Alexey Kodanev
2013-06-27 15:27 ` chrubis
2013-06-28 3:16 ` Caspar Zhang
2013-06-28 3:17 ` Wanlong Gao
2013-06-28 5:35 ` Mike Frysinger
2013-07-01 8:30 ` alexey.kodanev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D13E38.5010309@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox