From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Xie Lingyun <lingyun.xie@bj.cs2c.com.cn>, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 1/2 v3] xinetd/xinetd_tests.sh: cleanup tabs
Date: Thu, 11 Jul 2013 11:52:47 +0800 [thread overview]
Message-ID: <51DE2C0F.2090801@cn.fujitsu.com> (raw)
In-Reply-To: <20130711033505.GJ27609@aaa.aa>
On 07/11/2013 11:35 AM, Hangbin Liu wrote:
> On Thu, Jul 11, 2013 at 01:28:34AM +0800, Caspar Zhang wrote:
>> On 07/10/2013 07:03 PM, Xie Lingyun wrote:
>>> +defaults
>>> +{
>>> +instances = 25
>>> +log_type = FILE /var/log/servicelog
>>> +log_on_success = HOST PID
>>> +log_on_failure = HOST RECORD
>>> +disabled = telnet
>>> +}
>>
>> Generally looks good except here.
>>
>> better give a 4-space indentation inside the braces.
>>
>
> 1-tab or 4-space, I always be confuse which should we use. Even a tab should
> be 4 characters or 8 characters also have dispute. But the kernel coding style
> said Tabs are 8 characters, and thus indentations are also 8 characters.
>
> So, should we also use this style in shell scripts? Because I'm tired
> changing my vim config for each project.
We are just following kernel coding style in LTP.
Thanks,
Wanlong Gao
>
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-07-11 3:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 11:03 [LTP] [PATCH 1/2 v3] xinetd/xinetd_tests.sh: cleanup tabs Xie Lingyun
2013-07-10 11:03 ` [LTP] [PATCH 2/2 v3] xinetd/xinetd_tests.sh: add IPv6 test for xinetd Xie Lingyun
2013-07-10 17:30 ` Caspar Zhang
2013-07-11 7:43 ` Xie Lingyun
2013-07-11 8:00 ` Xie Lingyun
2013-07-11 8:03 ` Caspar Zhang
2013-07-12 0:45 ` Wanlong Gao
2013-07-11 7:55 ` Hangbin Liu
2013-07-10 17:28 ` [LTP] [PATCH 1/2 v3] xinetd/xinetd_tests.sh: cleanup tabs Caspar Zhang
2013-07-11 3:35 ` Hangbin Liu
2013-07-11 3:52 ` Wanlong Gao [this message]
2013-07-11 3:55 ` Caspar Zhang
2013-07-11 4:55 ` Hangbin Liu
2013-07-11 7:57 ` Xie Lingyun
2013-07-11 8:00 ` Caspar Zhang
2013-07-12 0:46 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DE2C0F.2090801@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=lingyun.xie@bj.cs2c.com.cn \
--cc=liuhangbin@gmail.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox