[LTP] [PATCH] Containers test case is hanging at two sub test cases

[LTP] [PATCH] Containers test case is hanging at two sub test cases

[Tejaswini]

Containers : testcase is preventing runfiv.sh from proceeding. Hangs at

>> two_children_ns and
>> par_chld_ipv6

The function crtchild() in two_children_ns.c and par_chld_ipv6.c is called
with only one parameter while the definition has two parameters: 
crtchild (char *, char *)

Signed-off-by: Tejaswini <tejaswin@linux.vnet.ibm.com>

The patches below fix the issue:

----

--- ltp-full-20130109/testcases/kernel/containers/netns/par_chld_ipv6.c.orig    2013-06-19 16:05:55.866360812 +0530
+++ ltp-full-20130109/testcases/kernel/containers/netns/par_chld_ipv6.c 2013-06-19 16:06:31.975150188 +0530
@@ -45,7 +45,7 @@
  #include "test.h"
  #include "config.h"

-extern int crtchild(char *);
+extern int crtchild(char *, char *);

  char *TCID = "netns_ipv6";
  int TST_TOTAL = 1;
@@ -95,7 +95,7 @@ int main()
  #else
                 tst_resm(TCONF, "System doesn't have unshare support");
  #endif
-               return crtchild(child);
+               return crtchild(child,par);
         } else {

                 //parent

--- ltp-full-20130109/testcases/kernel/containers/netns/two_children_ns.c.orig  2013-06-19 16:04:54.436982114 +0530
+++ ltp-full-20130109/testcases/kernel/containers/netns/two_children_ns.c       2013-06-19 16:05:22.427611441 +0530
@@ -47,7 +47,7 @@
  #include "libclone.h"
  #include "config.h"

-extern int crtchild(char *);
+extern int crtchild(char *, char *);

  char *TCID = "netns_2children";
  int TST_TOTAL = 1;
@@ -109,7 +109,7 @@ int main()
                                 return ret;
                         }
  #endif
-                       return crtchild(child[i]);
+                       return crtchild(child[i], par[i]);
                 } else {
                         //Parent

----

Thanks,
Tejaswini



------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Containers test case is hanging at two sub test cases

[chrubis]

Hi!
> >> two_children_ns and
> >> par_chld_ipv6
> 
> The function crtchild() in two_children_ns.c and par_chld_ipv6.c is called
> with only one parameter while the definition has two parameters: 
> crtchild (char *, char *)

The definition of the function should really be in some header
(presumbly common.h) and included in common.c and all the tests that
uses it (there are three instances of the wrong definiton of the
function at the moment).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list