From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH] ltp: handle missing online file
Date: Tue, 20 Aug 2013 15:34:39 -0500 [thread overview]
Message-ID: <5213D2DF.20802@oracle.com> (raw)
gather_node_cpus() fails if the /sys/devices/system/node/nodeX/cpuX/online
file is missing for any cpu other than cpu0. The absence of the online file
should not be treated as a failure, but as an indication that the cpu is
not hot-pluggable and cannot be taken offline.
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c
index 9bc926e..99243a6 100644
--- a/testcases/kernel/mem/lib/mem.c
+++ b/testcases/kernel/mem/lib/mem.c
@@ -786,16 +786,14 @@ static void gather_node_cpus(char *cpus, long nd)
if (path_exist(path, nd, i)) {
snprintf(path1, BUFSIZ, "%s/online", path);
/*
- * No cpu0/online knob, as it can't support to
- * on/offline cpu0, so if the 'nd' node contains
- * cpu0, it should skip to check cpu0/online's value.
+ * if there is no online knob, then the cpu cannot
+ * be taken offline
*/
- if (i == 0)
- goto next;
- SAFE_FILE_SCANF(cleanup, path1, "%ld", &online);
- if (online == 0)
- continue;
-next:
+ if (path_exist(path1)) {
+ SAFE_FILE_SCANF(cleanup, path1, "%ld", &online);
+ if (online == 0)
+ continue;
+ }
sprintf(buf, "%d,", i);
strcat(cpus, buf);
}
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2013-08-20 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 20:34 Dave Kleikamp [this message]
2013-08-21 6:31 ` [LTP] [PATCH] ltp: handle missing online file Wanlong Gao
2013-08-21 6:50 ` Jan Stancek
2013-08-21 12:19 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5213D2DF.20802@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox