From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VCmjT-00030T-A5 for ltp-list@lists.sourceforge.net; Fri, 23 Aug 2013 08:28:35 +0000 Received: from userp1040.oracle.com ([156.151.31.81]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1VCmjQ-0003g5-Sc for ltp-list@lists.sourceforge.net; Fri, 23 Aug 2013 08:28:35 +0000 Message-ID: <52171D26.9030008@oracle.com> Date: Fri, 23 Aug 2013 12:28:22 +0400 From: Stanislav Kholmanskikh MIME-Version: 1.0 References: <52122141.3020005@oracle.com> <1377157309-23572-1-git-send-email-stanislav.kholmanskikh@oracle.com> <893330423.2949965.1377244649561.JavaMail.root@redhat.com> In-Reply-To: <893330423.2949965.1377244649561.JavaMail.root@redhat.com> Subject: Re: [LTP] [PATCH V3 1/3] Added ALIGN, __ALIGN_MASK macroses List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Jan Stancek Cc: vasily isaenko , ltp-list@lists.sourceforge.net On 08/23/2013 11:57 AM, Jan Stancek wrote: > > ----- Original Message ----- >> From: "Stanislav Kholmanskikh" >> To: ltp-list@lists.sourceforge.net >> Cc: "vasily isaenko" , jstancek@redhat.com >> Sent: Thursday, 22 August, 2013 9:41:47 AM >> Subject: [PATCH V3 1/3] Added ALIGN, __ALIGN_MASK macroses >> >> Signed-off-by: Stanislav Kholmanskikh > The series looks good to me. I also ran it on small NUMA system, it worked fine. > My only nit is this patch's subject, I believe plural of macro is macros :-). Shame on me :) Sent V3.1 of this patch. > > Reviewed-by: Jan Stancek > >> --- >> include/test.h | 6 ++++++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/include/test.h b/include/test.h >> index d9eba31..a517ff9 100644 >> --- a/include/test.h >> +++ b/include/test.h >> @@ -105,6 +105,12 @@ >> #define MAP_PRIVATE_EXCEPT_UCLINUX MAP_PRIVATE >> #endif >> >> +/* Round x to the next multiple of a. >> + * a should be a power of 2. >> + */ >> +#define ALIGN(x, a) __ALIGN_MASK(x, (typeof(x))(a) - 1) >> +#define __ALIGN_MASK(x, mask) (((x) + (mask)) & ~(mask)) >> + >> /* >> * lib/forker.c >> */ >> -- >> 1.7.1 >> >> ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list