[LTP] [PATCH] ext4-new-features: fix syntax error in configure

[LTP] [PATCH] ext4-new-features: fix syntax error in configure

[Honggyu Kim]

In configure, string comparison is done using double assignment.
/bin/sh doesn't allow to compare strings using "==".
So "==" is modified to "=".

Signed-off-by: Honggyu Kim <hong.gyu.kim@lge.com>
---
 testcases/kernel/fs/ext4-new-features/configure |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/fs/ext4-new-features/configure b/testcases/kernel/fs/ext4-new-features/configure
index 13f43f9..12849e5 100755
--- a/testcases/kernel/fs/ext4-new-features/configure
+++ b/testcases/kernel/fs/ext4-new-features/configure
@@ -14,9 +14,9 @@ read EXT4_DEV
 
 echo "The partition is: $EXT4_DEV, Are you sure(Y/N)?"
 read RESULT
-if [ "$RESULT" == "Y" ] || [ "$RESULT" == "y" ]; then
+if [ "$RESULT" = "Y" ] || [ "$RESULT" = "y" ]; then
 	echo "EXT4_DEV=$EXT4_DEV" > ./ext4-test-config
-elif [ "$RESULT" == "N" ]; then
+elif [ "$RESULT" = "N" ]; then
 	echo "Give up specifing a partition!"
 else
 	echo "Your input is wrong($RESULT)."
-- 
1.7.9.5



------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] ext4-new-features: fix syntax error in configure

[Wanlong Gao]

On 10/28/2013 11:06 AM, Honggyu Kim wrote:
> In configure, string comparison is done using double assignment.
> /bin/sh doesn't allow to compare strings using "==".
> So "==" is modified to "=".
> 
> Signed-off-by: Honggyu Kim <hong.gyu.kim@lge.com>

Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

> ---
>  testcases/kernel/fs/ext4-new-features/configure |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/kernel/fs/ext4-new-features/configure b/testcases/kernel/fs/ext4-new-features/configure
> index 13f43f9..12849e5 100755
> --- a/testcases/kernel/fs/ext4-new-features/configure
> +++ b/testcases/kernel/fs/ext4-new-features/configure
> @@ -14,9 +14,9 @@ read EXT4_DEV
>  
>  echo "The partition is: $EXT4_DEV, Are you sure(Y/N)?"
>  read RESULT
> -if [ "$RESULT" == "Y" ] || [ "$RESULT" == "y" ]; then
> +if [ "$RESULT" = "Y" ] || [ "$RESULT" = "y" ]; then
>  	echo "EXT4_DEV=$EXT4_DEV" > ./ext4-test-config
> -elif [ "$RESULT" == "N" ]; then
> +elif [ "$RESULT" = "N" ]; then
>  	echo "Give up specifing a partition!"
>  else
>  	echo "Your input is wrong($RESULT)."
> 


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] ext4-new-features: fix syntax error in configure

[Wanlong Gao]

On 10/28/2013 11:06 AM, Honggyu Kim wrote:
> In configure, string comparison is done using double assignment.
> /bin/sh doesn't allow to compare strings using "==".
> So "==" is modified to "=".
> 
> Signed-off-by: Honggyu Kim <hong.gyu.kim@lge.com>

Applied, thank you.

Wanlong Gao


------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list