public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] setpgid03: use SIGUSR1 instead of sleep
Date: Wed, 30 Oct 2013 10:25:14 +0800	[thread overview]
Message-ID: <52706E0A.1030805@cn.fujitsu.com> (raw)
In-Reply-To: <1383033332-932-1-git-send-email-stanislav.kholmanskikh@oracle.com>

On 10/29/2013 03:55 PM, Stanislav Kholmanskikh wrote:
> I came accross the following rare issue:
> 
> setpgid03    1  TPASS  :  setpgid SUCCESS to set errno to EPERM
> setpgid03    2  TFAIL  :  setpgid FAILED, expect EACCES got 1
> 
> I suppose It may happen if the test host is under stress.
> To prevent this It would be better to use SIGUSR1 for parent-child
> synchronisations.
> 
> Also fixed error passing from children and performed a minor cleanup.
> 
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>


And it's better to split the cleanup part to another patch to make
your patch clear.

Thanks,
Wanlong Gao


------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      parent reply	other threads:[~2013-10-30  2:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29  7:55 [LTP] [PATCH] setpgid03: use SIGUSR1 instead of sleep Stanislav Kholmanskikh
2013-10-29 10:30 ` Jan Stancek
2013-10-29 11:54   ` Stanislav Kholmanskikh
2013-10-30  9:07   ` [LTP] [PATCH SERIES V2] " Stanislav Kholmanskikh
2013-10-30  9:07   ` [LTP] [PATCH V2 1/2] setpgid03: handle children errors and cleanup Stanislav Kholmanskikh
2013-10-30  9:07   ` [LTP] [PATCH V2 2/2] setpgid03: use SIGUSR1 instead of sleep Stanislav Kholmanskikh
2013-10-30 13:45     ` Jan Stancek
2013-10-31  7:54       ` Stanislav Kholmanskikh
2013-10-31 15:06         ` chrubis
     [not found]           ` <52727305.5070806@oracle.com>
2013-10-31 16:29             ` chrubis
     [not found]               ` <527B7485.2030809@oracle.com>
2013-11-07 11:30                 ` chrubis
2013-11-13  7:52                   ` [LTP] [RFC PATCH] tst_checkpoint_signal_child: implemented timeout Stanislav Kholmanskikh
2013-11-13  8:46                     ` Jan Stancek
2013-11-13  8:58                       ` Stanislav Kholmanskikh
2013-11-13  9:15                         ` [LTP] [RFC PATCH V2] " Stanislav Kholmanskikh
2013-11-13 17:50                           ` chrubis
2013-11-14  6:37                             ` [LTP] [PATCH V3 1/2] tst_res: added ETIME, ETIMEDOUT errno values Stanislav Kholmanskikh
2013-11-14 14:19                               ` chrubis
2013-11-14  6:37                             ` [LTP] [PATCH V3 2/2] tst_checkpoint_signal_child: implemented timeout Stanislav Kholmanskikh
2013-11-14  9:05                               ` Jan Stancek
2013-11-14 14:33                               ` chrubis
2013-12-12  9:21     ` [LTP] [PATCH V3 1/2] setpgid03: handle children errors and cleanup Stanislav Kholmanskikh
2013-12-12  9:21     ` [LTP] [PATCH V3 2/2] setpgid03: use tst_checkpoint interface Stanislav Kholmanskikh
2014-01-20 16:09       ` chrubis
     [not found]         ` <52DE7063.8070305@oracle.com>
2014-01-21 13:20           ` chrubis
2013-10-30  2:25 ` Wanlong Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52706E0A.1030805@cn.fujitsu.com \
    --to=gaowanlong@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=stanislav.kholmanskikh@oracle.com \
    --cc=vasily.isaenko@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox