[LTP] [PATCH v2] device-drivers: pci: check memory region for flag IORESOURCE_PREFETCH

[LTP] [PATCH v2] device-drivers: pci: check memory region for flag IORESOURCE_PREFETCH

[Alexey Kodanev]

This is done to make sure there will be no side effects if we change it somehow
in the test (e.g. we're not changing I/O ports implemented as memory regions).
Remove annoying printk messages.

Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
---
 .../device-drivers/pci/tpci_kernel/ltp_tpci.c      |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c b/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
index 4e92f5e..d2ffacd 100644
--- a/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
+++ b/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
@@ -99,8 +99,6 @@ static int probe_pci_dev(unsigned int bus, unsigned int slot)
 {
 	struct pci_dev *dev;
 
-	prk_info("find arbitrary pci device for test");
-
 	if (ltp_pci.dev) {
 		pci_dev_put(ltp_pci.dev);
 		ltp_pci.dev = NULL;
@@ -467,7 +465,8 @@ static int test_assign_resources(void)
 			r->name, r->flags,
 			(unsigned long)r->start, (unsigned long)r->end);
 
-		if ((r->flags & IORESOURCE_MEM) == IORESOURCE_MEM) {
+		if (r->flags & IORESOURCE_MEM &&
+			r->flags & IORESOURCE_PREFETCH) {
 			ret = pci_assign_resource(dev, i);
 			prk_info("assign resource to '%d', ret '%d'", i, ret);
 			rc |= (ret < 0 && ret != -EBUSY) ? TFAIL : TPASS;
@@ -718,8 +717,6 @@ static ssize_t sys_bus_slot(struct device *dev,
 	bus = res >> 8 & 0xFF;
 	slot = res & 0xFF;
 
-	prk_info("get bus '%u' slot '%u'", bus, slot);
-
 	ret = probe_pci_dev(bus, slot);
 	if (ret)
 		return ret;
-- 
1.7.1


------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2] device-drivers: pci: check memory region for flag IORESOURCE_PREFETCH

[Wanlong Gao]

On 10/29/2013 10:04 PM, Alexey Kodanev wrote:
> This is done to make sure there will be no side effects if we change it somehow
> in the test (e.g. we're not changing I/O ports implemented as memory regions).
> Remove annoying printk messages.
> 
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>

Thank you for investigating this out, applied.

Wanlong Gao


------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list