[LTP] [PATCH] sctp: enlarge SO_RCVBUF option value

[LTP] [PATCH] sctp: enlarge SO_RCVBUF option value

[Simon Xu]

When using setsockopt() with recent Linux kernels, it doesn't make sense to
use a value smaller than SOCK_MIN_RCVBUF/2 for SO_RCVBUF and expect getting
a SO_RCVBUF value by getsockopt() which is doubled.  See the following code
in linux/net/core/sock.c:

	if ((val * 2) < SOCK_MIN_RCVBUF)
		sk->sk_rcvbuf = SOCK_MIN_RCVBUF;
	else
		sk->sk_rcvbuf = val * 2;
	break;

SOCK_MIN_RCVBUF is defined as (2048 + sizeof(struct sk_buff)) which is 2240.
---
 testcases/network/sctp/func_tests/test_1_to_1_sockopt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/network/sctp/func_tests/test_1_to_1_sockopt.c b/testcases/network/sctp/func_tests/test_1_to_1_sockopt.c
index b12313b..c36f502 100644
--- a/testcases/network/sctp/func_tests/test_1_to_1_sockopt.c
+++ b/testcases/network/sctp/func_tests/test_1_to_1_sockopt.c
@@ -299,9 +299,9 @@ int main(void)
 	tst_resm(TPASS, "getsockopt() SCTP_STATUS - SUCCESS");
 
 	/* Reducing the SO_RCVBUF value using setsockopt() */
-	/*Minimum value is 128 and hence I am using it */
 	len = sizeof(int);
-	rcvbuf_val_set = 128;
+	/* (rcvbuf len)*2 should be no less than SOCK_MIN_RCVBUF in kernel */
+	rcvbuf_val_set = 1500;
 	/* TEST16: Test case for setsockopt SO_RCVBUF */
 	error = setsockopt(sk2, SOL_SOCKET, SO_RCVBUF, &rcvbuf_val_set, len);
 	if (error < 0)
-- 
1.8.1.2


------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] sctp: enlarge SO_RCVBUF option value

[Jan Stancek]

----- Original Message -----
> From: "Simon Xu" <xu.simon@oracle.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Monday, 4 November, 2013 6:28:15 AM
> Subject: [LTP] [PATCH] sctp: enlarge SO_RCVBUF option value
> 
> When using setsockopt() with recent Linux kernels, it doesn't make sense to
> use a value smaller than SOCK_MIN_RCVBUF/2 for SO_RCVBUF and expect getting
> a SO_RCVBUF value by getsockopt() which is doubled.  See the following code
> in linux/net/core/sock.c:
> 
> 	if ((val * 2) < SOCK_MIN_RCVBUF)
> 		sk->sk_rcvbuf = SOCK_MIN_RCVBUF;
> 	else
> 		sk->sk_rcvbuf = val * 2;
> 	break;
> 
> SOCK_MIN_RCVBUF is defined as (2048 + sizeof(struct sk_buff)) which is 2240.
> ---

You are missing 'Signed-off-by', but patch looks good to me.

Reviewed-by: Jan Stancek <jstancek@redhat.com>

Regards,
Jan

>  testcases/network/sctp/func_tests/test_1_to_1_sockopt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/network/sctp/func_tests/test_1_to_1_sockopt.c
> b/testcases/network/sctp/func_tests/test_1_to_1_sockopt.c
> index b12313b..c36f502 100644
> --- a/testcases/network/sctp/func_tests/test_1_to_1_sockopt.c
> +++ b/testcases/network/sctp/func_tests/test_1_to_1_sockopt.c
> @@ -299,9 +299,9 @@ int main(void)
>  	tst_resm(TPASS, "getsockopt() SCTP_STATUS - SUCCESS");
>  
>  	/* Reducing the SO_RCVBUF value using setsockopt() */
> -	/*Minimum value is 128 and hence I am using it */
>  	len = sizeof(int);
> -	rcvbuf_val_set = 128;
> +	/* (rcvbuf len)*2 should be no less than SOCK_MIN_RCVBUF in kernel */
> +	rcvbuf_val_set = 1500;
>  	/* TEST16: Test case for setsockopt SO_RCVBUF */
>  	error = setsockopt(sk2, SOL_SOCKET, SO_RCVBUF, &rcvbuf_val_set, len);
>  	if (error < 0)
> --
> 1.8.1.2
> 
> 
> ------------------------------------------------------------------------------
> Android is increasing in popularity, but the open development platform that
> developers love is also attractive to malware creators. Download this white
> paper to learn more about secure code signing practices that can help keep
> Android apps secure.
> http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] sctp: enlarge SO_RCVBUF option value

[Wanlong Gao]

On 11/04/2013 01:28 PM, Simon Xu wrote:
> When using setsockopt() with recent Linux kernels, it doesn't make sense to
> use a value smaller than SOCK_MIN_RCVBUF/2 for SO_RCVBUF and expect getting
> a SO_RCVBUF value by getsockopt() which is doubled.  See the following code
> in linux/net/core/sock.c:
> 
> 	if ((val * 2) < SOCK_MIN_RCVBUF)
> 		sk->sk_rcvbuf = SOCK_MIN_RCVBUF;
> 	else
> 		sk->sk_rcvbuf = val * 2;
> 	break;
> 
> SOCK_MIN_RCVBUF is defined as (2048 + sizeof(struct sk_buff)) which is 2240.
> ---
>  testcases/network/sctp/func_tests/test_1_to_1_sockopt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thank you. Please add your Signed-off-by next time as Jan pointed out.

Wanlong Gao


------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list