From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Honggyu Kim <hong.gyu.kim@lge.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] acct01: add a check routine for acct implementation
Date: Wed, 06 Nov 2013 10:29:13 +0800 [thread overview]
Message-ID: <5279A979.3020302@cn.fujitsu.com> (raw)
In-Reply-To: <005301ceda93$558302a0$008907e0$@gyu.kim@lge.com>
On 11/06/2013 09:55 AM, Honggyu Kim wrote:
> A check routine for acct implementation is added at the beginning of the test.
> check_acct_in_kernel function calls acct(NULL) and checks if errno is ENOSYS.
> It means that acct system call is not implemented in kernel.
> The other ENOSYS check routines in setup are removed.
>
> This patch prevents from unintentional calling acct again in cleanup, which
> makes TCONF to TBROK and helps configuration problems stay as TCONF.
>
> Previous test output: (becomes TBROK in the end)
> acct01 1 TCONF : BSD process accounting is not configured in this kernel
> acct01 2 TCONF : Remaining cases not appropriate for configuration
> acct01 3 TBROK : acct(NULL) failed: errno=ENOSYS(38): Function not implemented
>
> Fixed test output: (stays as TCONF)
> acct01 1 TCONF : BSD process accounting is not configured in this kernel
>
> Signed-off-by: Honggyu Kim <hong.gyu.kim@lge.com>
> ---
> testcases/kernel/syscalls/acct/acct01.c | 32 +++++++++++++++++--------------
> 1 file changed, 18 insertions(+), 14 deletions(-)
Applied with removing the unnecessary braces, thank you.
Wanlong Gao
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-11-06 2:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 1:55 [LTP] [PATCH v2] acct01: add a check routine for acct implementation Honggyu Kim
2013-11-06 2:29 ` Wanlong Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5279A979.3020302@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=hong.gyu.kim@lge.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox