From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VkwOG-0003H1-R3 for ltp-list@lists.sourceforge.net; Mon, 25 Nov 2013 13:39:52 +0000 Received: from aserp1040.oracle.com ([141.146.126.69]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1VkwOE-0006rO-NE for ltp-list@lists.sourceforge.net; Mon, 25 Nov 2013 13:39:52 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rAPDdiCd023274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Nov 2013 13:39:45 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rAPDdgJY025768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 25 Nov 2013 13:39:44 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rAPDdgCY023407 for ; Mon, 25 Nov 2013 13:39:42 GMT Message-ID: <5293531A.5090402@oracle.com> Date: Mon, 25 Nov 2013 21:39:38 +0800 From: Simon Xu MIME-Version: 1.0 References: <20131111141503.GE12164@rei> <1384841690-716-1-git-send-email-xu.simon@oracle.com> In-Reply-To: <1384841690-716-1-git-send-email-xu.simon@oracle.com> Subject: Re: [LTP] [PATCH V4] rpc01: fix paths and add Makefile for datafiles List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: ltp-list@lists.sourceforge.net Could anyone help to review? Thanks Simon On 2013/11/19 14:14, Simon Xu wrote: > 1) fix $TCbin > 2) eliminate $TCtmp, use $TMPDIR instead > 3) The files in datafiles dir are needed in the test but they are not > installed. Create a Makefile in datafiles to install the files. > > Signed-off-by: Simon Xu > --- > testcases/network/rpc/basic_tests/rpc01/Makefile | 4 ++- > .../rpc/basic_tests/rpc01/datafiles/Makefile | 29 ++++++++++++++++++++++ > testcases/network/rpc/basic_tests/rpc01/rpc01 | 9 +++---- > 3 files changed, 36 insertions(+), 6 deletions(-) > create mode 100644 testcases/network/rpc/basic_tests/rpc01/datafiles/Makefile > > diff --git a/testcases/network/rpc/basic_tests/rpc01/Makefile b/testcases/network/rpc/basic_tests/rpc01/Makefile > index ba3fe0a..732d816 100644 > --- a/testcases/network/rpc/basic_tests/rpc01/Makefile > +++ b/testcases/network/rpc/basic_tests/rpc01/Makefile > @@ -29,4 +29,6 @@ CPPFLAGS += -Wno-error > > INSTALL_TARGETS := rpc01 > > -include $(top_srcdir)/include/mk/generic_leaf_target.mk > +SUBDIRS := datafiles > + > +include $(top_srcdir)/include/mk/generic_trunk_target.mk > diff --git a/testcases/network/rpc/basic_tests/rpc01/datafiles/Makefile b/testcases/network/rpc/basic_tests/rpc01/datafiles/Makefile > new file mode 100644 > index 0000000..92370e6 > --- /dev/null > +++ b/testcases/network/rpc/basic_tests/rpc01/datafiles/Makefile > @@ -0,0 +1,29 @@ > +# > +# network/rpc/basic_tests/rpc01/datafiles Makefile. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License along > +# with this program; if not, write to the Free Software Foundation, Inc., > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > +# > +# Simon Xu Nov 8 2013 > +# > + > +top_srcdir ?= ../../../../../.. > + > +include $(top_srcdir)/include/mk/env_pre.mk > + > +INSTALL_DIR := testcases/bin/datafiles > + > +INSTALL_TARGETS := file* > + > +include $(top_srcdir)/include/mk/generic_leaf_target.mk > diff --git a/testcases/network/rpc/basic_tests/rpc01/rpc01 b/testcases/network/rpc/basic_tests/rpc01/rpc01 > index ef97a95..7eed86d 100755 > --- a/testcases/network/rpc/basic_tests/rpc01/rpc01 > +++ b/testcases/network/rpc/basic_tests/rpc01/rpc01 > @@ -36,9 +36,8 @@ > $trace_logic > this_file=${0##*/} > TC=${TC:=rpc01} > -TCbin=${TCbin:=`pwd`} > +TCbin=${TCbin:=$LTPROOT/testcases/bin} > TCdat=${TCdat:=$TCbin/datafiles} > -TCtmp=${TCtmp:=$LTPROOT/testcases/bin} > NUMLOOPS=${NUMLOOPS:=3} > RHOST=${RHOST:=`hostname`} > CLEANUP=${CLEANUP:="ON"} > @@ -68,7 +67,7 @@ do_test() > do > for FILE in $DATAFILES > do > - $TCtmp/rpc1 -s $RHOST -f $TCdat/$FILE > + rpc1 -s $RHOST -f $TCdat/$FILE > [ $? -eq 0 ] || end_testcase "Fail on using $FILE" > done > COUNT=`expr $COUNT + 1` > @@ -90,9 +89,9 @@ do_cleanup() > $trace_logic > > if [ "$CLEANUP" = "ON" ]; then > - if [ -f $TCtmp/core ]; then > + if [ -f $TMPDIR/core ]; then > echo "Core file is saved in /tmp" > - mv $TCtmp/core /tmp > + mv $TMPDIR/core /tmp > fi > > # Kill server ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list