Re: [LTP] [PATCH v2 1/2] confstr/confstr01.c: cleanup

Re: [LTP] [PATCH v2 1/2] confstr/confstr01.c: cleanup

[chrubis]

Hi!
> cleanup the confstr01.c test case.
> 

I've changed the succes message to include the confstr value as:

                                } else {
-                                       tst_resm(TPASS, "confstr %s success",
-                                                test_cases[i].name);
+                                       tst_resm(TPASS, "confstr %s = '%s'",
+                                                test_cases[i].name, buf);
                                }
                                free(buf);

And pushed both patches, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2 1/2] confstr/confstr01.c: cleanup

[Markos Chandras]

On 11/28/2013 01:59 PM, chrubis@suse.cz wrote:
> Hi!
>> cleanup the confstr01.c test case.
>>
>
> I've changed the succes message to include the confstr value as:
>
>                                  } else {
> -                                       tst_resm(TPASS, "confstr %s success",
> -                                                test_cases[i].name);
> +                                       tst_resm(TPASS, "confstr %s = '%s'",
> +                                                test_cases[i].name, buf);
>                                  }
>                                  free(buf);
>
> And pushed both patches, thanks.
>

Hi,

since this change I am seeing the following build problem on a uClibc 
based system

confstr01.c:50: error: '_CS_XBS5_ILP32_OFF32_CFLAGS' undeclared here 
(not in a function)
confstr01.c:51: error: '_CS_XBS5_ILP32_OFF32_LDFLAGS' undeclared here 
(not in a function)
confstr01.c:52: error: '_CS_XBS5_ILP32_OFF32_LIBS' undeclared here (not 
in a function)
confstr01.c:53: error: '_CS_XBS5_ILP32_OFF32_LINTFLAGS' undeclared here 
(not in a function)
...

Reverting the recent changes in confstr01.c file seems to "fix" the problem.

-- 
markos


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2 1/2] confstr/confstr01.c: cleanup

[chrubis]

Hi!
> >> cleanup the confstr01.c test case.
> >>
> >
> > I've changed the succes message to include the confstr value as:
> >
> >                                  } else {
> > -                                       tst_resm(TPASS, "confstr %s success",
> > -                                                test_cases[i].name);
> > +                                       tst_resm(TPASS, "confstr %s = '%s'",
> > +                                                test_cases[i].name, buf);
> >                                  }
> >                                  free(buf);
> >
> > And pushed both patches, thanks.
> >
> 
> Hi,
> 
> since this change I am seeing the following build problem on a uClibc 
> based system
> 
> confstr01.c:50: error: '_CS_XBS5_ILP32_OFF32_CFLAGS' undeclared here 
> (not in a function)
> confstr01.c:51: error: '_CS_XBS5_ILP32_OFF32_LDFLAGS' undeclared here 
> (not in a function)
> confstr01.c:52: error: '_CS_XBS5_ILP32_OFF32_LIBS' undeclared here (not 
> in a function)
> confstr01.c:53: error: '_CS_XBS5_ILP32_OFF32_LINTFLAGS' undeclared here 
> (not in a function)
> ...
> 
> Reverting the recent changes in confstr01.c file seems to "fix" the problem.

Hmm, I looked closely at the changes and that may be the missing _XOPEN_SOURCE.

Does it work after adding:

#define _XOPEN_SOURCE 500

before headers are included?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2 1/2] confstr/confstr01.c: cleanup

[chrubis]

Hi!
> Hello,
> 
> Yep, that works fine. Thanks!

Fix pushed.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2 1/2] confstr/confstr01.c: cleanup

[chrubis]

Hi!
> > Hello,
> > 
> > Yep, that works fine. Thanks!
> 
> Fix pushed.

And I've failed to do it right at the first time...

I've did a force push (these are generally wrong thing to do, but this
is a rare expception when it makes sense). If you pulled the wrong
version, reset the last commit and pull again.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list