From: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
To: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH] controllers/memcg_lib.sh: reset root cgroup's memory.use_hierarchy to 0
Date: Thu, 26 Dec 2013 20:52:45 +0800 [thread overview]
Message-ID: <52BC269D.9060009@cn.fujitsu.com> (raw)
For some linux distribution, such as RHEL7U0Beta,
memory.use_hierarchy is 1 by default, which will caused some tests
failed, such as memcg_stat_test.sh. According to kernel
Documentation/cgroups/memory.txt's description, the default value
should be 0, and some ltp tests are written based on this assumption,
so here we reset the root cgroup's memory.use_hierarchy to 0
before the test.
Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
---
.../controllers/memcg/functional/memcg_lib.sh | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/testcases/kernel/controllers/memcg/functional/memcg_lib.sh b/testcases/kernel/controllers/memcg/functional/memcg_lib.sh
index 16e30ec..f93b291 100755
--- a/testcases/kernel/controllers/memcg/functional/memcg_lib.sh
+++ b/testcases/kernel/controllers/memcg/functional/memcg_lib.sh
@@ -38,6 +38,7 @@ HUGEPAGESIZE=`grep Hugepagesize /proc/meminfo | awk '{ print $2 }'`
HUGEPAGESIZE=$(( $HUGEPAGESIZE * 1024 ))
PASS=0
FAIL=1
+orig_memory_use_hierarchy="none"
cur_id=0
failed=0
@@ -396,6 +397,15 @@ test_move_charge()
cleanup()
{
+ if [ "$orig_memory_use_hierarchy" != "none" ];then
+ echo $orig_memory_use_hierarchy > \
+ /dev/memcg/memory.use_hierarchy
+ if [ $? -ne 0 ];then
+ tst_resm TINFO "restore "\
+ "/dev/memcg/memory.use_hierarchy failed"
+ fi
+ fi
+ orig_memory_use_hierarchy="none"
killall -9 memcg_process 2>/dev/null
if [ -e /dev/memcg ]; then
umount /dev/memcg 2>/dev/null
@@ -409,4 +419,17 @@ do_mount()
mkdir /dev/memcg 2> /dev/null
mount -t cgroup -omemory memcg /dev/memcg
+
+ # For some linux distribution, such as RHEL7U0Beta,
+ # memory.use_hierarchy is 1 by default, which will caused some tests
+ # failed, such as memcg_stat_test.sh. According to kernel
+ # Documentation/cgroups/memory.txt's description, the default value
+ # should be 0, and some ltp tests are written based on this assumption,
+ # so here we reset the root cgroup's memory.use_hierarchy to 0
+ # before the test.
+ orig_memory_use_hierarchy=$(cat /dev/memcg/memory.use_hierarchy)
+ echo 0 > /dev/memcg/memory.use_hierarchy
+ if [ $? -ne 0 ];then
+ tst_resm TINFO "set /dev/memcg/memory.use_hierarchy to 0 failed"
+ fi
}
--
1.8.2.1
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2013-12-26 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 12:52 Xiaoguang Wang [this message]
2014-02-12 9:12 ` [LTP] [PATCH v2] controllers/memcg_lib.sh: reset root cgroup's memory.use_hierarchy to 0 Xiaoguang Wang
2014-02-13 16:43 ` [LTP] [PATCH] " chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BC269D.9060009@cn.fujitsu.com \
--to=wangxg.fnst@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox