Re: [LTP] [PATCH 2/2] kernel/mem/lib/mem.c: do the necessary cleanup work

[Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>]

Hi,

On 04/28/2014 06:56 PM, Stanislav Kholmanskikh wrote:
> Hi!
>
> On 04/28/2014 12:47 PM, Xiaoguang Wang wrote:
>> Oom01 case will modify "/proc/sys/vm/overcommit_memory" to have tests. In most systems,
>> the overcommit_memory's default value is 0. When running oom01, if KSM configuration
>> is not enabled, "tst_brkm(TCONF, NULL, ...)" will be called, in this case, we will forget
>> to execute the restore operation defined in cleanup, and this will impact other test cases
>> in LTP, for example, fork14 in RHEL5 will succeed unexpectedly.
>>
>> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
>> ---
>>   testcases/kernel/mem/lib/mem.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c
>> index f145a2a..69a9014 100644
>> --- a/testcases/kernel/mem/lib/mem.c
>> +++ b/testcases/kernel/mem/lib/mem.c
>> @@ -146,7 +146,7 @@ void testoom(int mempolicy, int lite)
>>   	oom(MLOCK, lite);
>>
>>   	if (access(PATH_KSM, F_OK) == -1)
>> -		tst_brkm(TCONF, NULL, "KSM configuration is not enabled");
>> +		tst_brkm(TCONF, cleanup, "KSM configuration is not enabled");
> In the current situation the OOM test cases will exit with TCONF if no 
> KSM is setup on the system.
>
> But is KSM the absolute requirement for the test cases?
According to my understanding about oom01, this is not a mandatory requirement :-)
>
> And could we execute the KSM part of testoom() only if KSM is enabled?
Yeah, sound reasonable, thanks. I will make a new version soon.

Regards,
Xiaoguang Wang
>
> Thanks.
>
>>   	tst_resm(TINFO, "start OOM testing for KSM pages.");
>>   	oom(KSM, lite);
>>
> ------------------------------------------------------------------------------
> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
> unparalleled scalability from the best Selenium testing platform available.
> Simple to use. Nothing to install. Get started now for free."
> http://p.sf.net/sfu/SauceLabs
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>


------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list