Re: [LTP] [PATCH 1/2] syscalls/fstatfs: Cleanup

[Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>]

Hi!

On 04/30/2014 01:26 PM, shuang.qiu@oracle.com wrote:
> From: Shuang Qiu <shuang.qiu@oracle.com>
>
> * Delete some useless comments
>
> * Make variables and functions static
>
> Signed-off-by: Shuang Qiu <shuang.qiu@oracle.com>

Reviewed-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>

And I would personally add these small changes (can be done at pushing 
time):

diff --git a/testcases/kernel/syscalls/fstatfs/fstatfs02.c 
b/testcases/kernel/syscalls/fstatfs/fstatfs02.c
index b243af3..99dc51b 100644
--- a/testcases/kernel/syscalls/fstatfs/fstatfs02.c
+++ b/testcases/kernel/syscalls/fstatfs/fstatfs02.c
@@ -67,14 +67,12 @@ int main(int ac, char **av)

         setup();

-       /* set up the expected errnos */
         TEST_EXP_ENOS(exp_enos);

         for (lc = 0; TEST_LOOPING(lc); lc++) {

                 tst_count = 0;

-               /* loop through the test cases */
                 for (i = 0; i < TST_TOTAL; i++) {

                         TEST(fstatfs(TC[i].fd, TC[i].sbuf));

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list