From: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH RFC] change MAKE_TARGETS's dependency to normal prerequisites and order-only prerequisites
Date: Thu, 15 May 2014 17:22:56 +0800 [thread overview]
Message-ID: <53748770.8090806@cn.fujitsu.com> (raw)
In-Reply-To: <948116490.5076233.1400060143816.JavaMail.zimbra@redhat.com>
Hi,
On 05/14/2014 05:35 PM, Jan Stancek wrote:
>
>
> ----- Original Message -----
>> From: "Xiaoguang Wang" <wangxg.fnst@cn.fujitsu.com>
>> To: ltp-list@lists.sourceforge.net
>> Sent: Wednesday, 14 May, 2014 11:17:35 AM
>> Subject: [LTP] [PATCH RFC] change MAKE_TARGETS's dependency to normal prerequisites and order-only prerequisites
>>
>> See the below issue:
>> When we made modifications to source files in lib/, for example
>> lib/tst_mkfs.c, then
>> back to testcases/kernel/syscalls/access and execute 'make'. This will not
>> make the
>> access[0-5] to be re-linked with the newly generated libltp.a, we need to
>> touch
>> access[0-5].c or remove access[0-5] files first, then make. This will make
>> no sense.
>> Users may expect just a make command to ensure a new access[0-5] generated
>> with the
>> new libltp.a.
>>
>> This is because in 'include/mk/generic_leaf_target.inc', MAKE_TARGETS's
>> dependency is
>> order-only prerequisites, not normal prerequisites, so we change lib's
>> dependency type
>> to normal prerequisites, not order-only prerequisites.
>>
>> The original MAKE_DEPS is replaced by MAKE_NORMAL_DEPS or
>> MAKE_ORDER_ONLY_DEPS.
>>
>> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
>> ---
>> include/mk/generic_leaf_target.inc | 2 +-
>> include/mk/generic_trunk_target.inc | 2 +-
>> include/mk/testcases.mk | 3 ++-
>> testcases/kernel/Makefile | 2 +-
>> testcases/kernel/containers/Makefile | 2 +-
>> testcases/kernel/containers/Makefile.inc | 2 +-
>> testcases/kernel/controllers/Makefile | 2 +-
>> testcases/kernel/controllers/Makefile.inc | 2 +-
>> testcases/kernel/controllers/cpuset/Makefile | 2 +-
>> testcases/kernel/controllers/cpuset/Makefile.inc | 2 +-
>> testcases/kernel/include/lib.mk | 2 +-
>> testcases/kernel/mem/hugetlb/Makefile | 2 +-
>> testcases/kernel/mem/hugetlb/Makefile.inc | 2 +-
>> testcases/kernel/mem/include/libmem.mk | 2 +-
>> testcases/kernel/power_management/Makefile | 2 +-
>> testcases/kernel/syscalls/ipc/Makefile | 2 +-
>> testcases/kernel/syscalls/ipc/Makefile.inc | 2 +-
>> testcases/kernel/syscalls/ipc/msgctl/Makefile | 2 +-
>> testcases/kernel/syscalls/kill/Makefile | 2 +-
>> testcases/kernel/syscalls/mremap/Makefile | 2 +-
>> testcases/network/rpc/basic_tests/rpc01/Makefile | 2 +-
>> testcases/network/rpc/rpc-tirpc/tests_pack/Makefile.inc | 2 +-
>> testcases/network/tcp_cmds/Makefile.inc | 4 ++--
>> 23 files changed, 25 insertions(+), 24 deletions(-)
>>
> <snip>
>> diff --git a/testcases/kernel/include/lib.mk
>> b/testcases/kernel/include/lib.mk
>> index c193ca3..c0b9189 100644
>> --- a/testcases/kernel/include/lib.mk
>> +++ b/testcases/kernel/include/lib.mk
>> @@ -32,7 +32,7 @@ $(LIBKERNTEST_DIR):
>> $(LIBKERNTEST): $(LIBKERNTEST_DIR)
>> $(MAKE) -C $^ -f "$(LIBKERNTEST_SRCDIR)/Makefile" all
>>
>> -MAKE_DEPS += $(LIBKERNTEST)
>> +MAKE_ORDER_ONLY_DEPS += $(LIBKERNTEST)
> Hi,
>
> Why is libkerntest.a order only dependency here?
> If we go this way, shouldn't we do it for all libraries?
Agree, thanks.
I will send a new version later :-)
Regards,
Xiaoguang Wang
>
> Regards,
> Jan
> .
>
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-05-15 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 9:17 [LTP] [PATCH RFC] change MAKE_TARGETS's dependency to normal prerequisites and order-only prerequisites Xiaoguang Wang
2014-05-14 9:35 ` Jan Stancek
2014-05-15 9:22 ` Xiaoguang Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53748770.8090806@cn.fujitsu.com \
--to=wangxg.fnst@cn.fujitsu.com \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox