From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: Mike Frysinger <vapier@gentoo.org>, ltp-list@lists.sourceforge.net
Cc: vasily.isaenko@oracle.com
Subject: Re: [LTP] [PATCH V3 1/4] testscripts/isofs.sh: cleanup
Date: Mon, 16 Jun 2014 16:29:01 +0400 [thread overview]
Message-ID: <539EE30D.3070003@oracle.com> (raw)
In-Reply-To: <3170652.sUSmuoD47v@vapier>
Hi!
On 06/16/2014 10:22 AM, Mike Frysinger wrote:
> On Thu 27 Mar 2014 18:22:52 Stanislav Kholmanskikh wrote:
>> +MNT_POINT="/tmp/isofs_$$"
>> +COPY_DIR="/etc/"
>> +TEMP_DIR="/tmp/for_isofs_test"
>> +MAKE_FILE_SYS_DIR=$TEMP_DIR$COPY_DIR
>
> not really a new issue, but scripts really should never hardcode paths in
> /tmp/ or to that dir at all. this is what `mktemp -d` is for.
>
>> +if [ "$NO_CLEANUP" == "no" ]; then
>
> it is "=" in POSIX, not "=="
> -mike
>
Thank you for review.
But both issues are fixed in the next patch in the sequence - "[PATCH V3
2/4] testscripts/isofs.sh: use the new shell interface".
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-06-16 12:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 14:22 [LTP] isofs.sh series V3 Stanislav Kholmanskikh
2014-03-27 14:22 ` [LTP] [PATCH V3 1/4] testscripts/isofs.sh: cleanup Stanislav Kholmanskikh
2014-06-16 6:22 ` Mike Frysinger
2014-06-16 12:29 ` Stanislav Kholmanskikh [this message]
2014-03-27 14:22 ` [LTP] [PATCH V3 2/4] testscripts/isofs.sh: use the new shell interface Stanislav Kholmanskikh
2014-03-27 14:22 ` [LTP] [PATCH V3 3/4] testscripts/isofs.sh: removed some "unnecessary" steps Stanislav Kholmanskikh
2014-04-29 15:29 ` chrubis
2014-04-29 15:30 ` chrubis
[not found] ` <5368C827.1020007@oracle.com>
2014-05-06 13:17 ` chrubis
2014-06-16 6:23 ` Mike Frysinger
2014-06-16 12:30 ` Stanislav Kholmanskikh
2014-03-27 14:22 ` [LTP] [PATCH V3 4/4] Declare an iso9660 fs testcase based on isofs.sh Stanislav Kholmanskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539EE30D.3070003@oracle.com \
--to=stanislav.kholmanskikh@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox