[LTP] [PATCH] madvise05: new testcase for Oops in madvise_willneed

[LTP] [PATCH] madvise05: new testcase for Oops in madvise_willneed

[Jan Stancek]

This is a regression test for madvise(2) system call. It tests
kernel for NULL ptr deref Oops fixed by:
  commit ee53664bda169f519ce3c6a22d378f0b946c8178
  Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
  Date:   Fri Dec 20 15:10:03 2013 +0200
    mm: Fix NULL pointer dereference in madvise(MADV_WILLNEED) support

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 runtest/syscalls                              |    1 +
 testcases/kernel/syscalls/.gitignore          |    1 +
 testcases/kernel/syscalls/madvise/madvise05.c |   81 +++++++++++++++++++++++++
 3 files changed, 83 insertions(+), 0 deletions(-)
 create mode 100644 testcases/kernel/syscalls/madvise/madvise05.c

diff --git a/runtest/syscalls b/runtest/syscalls
index 5e6e0f4..142c350 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -715,6 +715,7 @@ madvise01 madvise01
 madvise02 madvise02
 madvise03 madvise03
 madvise04 madvise04
+madvise05 madvise05
 
 newuname01 newuname01
 
diff --git a/testcases/kernel/syscalls/.gitignore b/testcases/kernel/syscalls/.gitignore
index fb2425e..fd52217 100644
--- a/testcases/kernel/syscalls/.gitignore
+++ b/testcases/kernel/syscalls/.gitignore
@@ -479,6 +479,7 @@
 /madvise/madvise02
 /madvise/madvise03
 /madvise/madvise04
+/madvise/madvise05
 /mallopt/mallopt01
 /mbind/mbind01
 /memcmp/memcmp01
diff --git a/testcases/kernel/syscalls/madvise/madvise05.c b/testcases/kernel/syscalls/madvise/madvise05.c
new file mode 100644
index 0000000..043eb4d
--- /dev/null
+++ b/testcases/kernel/syscalls/madvise/madvise05.c
@@ -0,0 +1,81 @@
+/*
+ *  Copyright (c) Linux Test Project, 2014
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU Library General Public License for more details.
+ */
+/*
+ * This is a regression test for madvise(2) system call. It tests kernel
+ * for NULL ptr deref Oops fixed by:
+ *   commit ee53664bda169f519ce3c6a22d378f0b946c8178
+ *   Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
+ *   Date:   Fri Dec 20 15:10:03 2013 +0200
+ *     mm: Fix NULL pointer dereference in madvise(MADV_WILLNEED) support
+ *
+ * On buggy kernel with CONFIG_DEBUG_LOCK_ALLOC=y this testcase should
+ * produce Oops and/or be killed. On fixed/good kernel this testcase
+ * runs to completion (retcode is 0)
+ */
+
+#include <sys/mman.h>
+#include <errno.h>
+
+#include "test.h"
+#include "usctest.h"
+#include "safe_macros.h"
+
+#define ALLOC_SIZE (32 * 1024 * 1024)
+
+static void setup(void);
+static void cleanup(void);
+
+char *TCID = "madvise05";
+int TST_TOTAL = 1;
+
+int main(int argc, char *argv[])
+{
+	int lc;
+	const char *msg = NULL;
+	void *p;
+
+	msg = parse_opts(argc, argv, NULL, NULL);
+	if (msg)
+		tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
+
+	setup();
+
+	for (lc = 0; TEST_LOOPING(lc); lc++) {
+		p = SAFE_MMAP(cleanup, NULL, ALLOC_SIZE, PROT_READ,
+			MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0);
+		TEST(mprotect(p, ALLOC_SIZE, PROT_NONE));
+		if (TEST_RETURN == -1)
+			tst_brkm(TBROK | TTERRNO, cleanup, "mprotect failed");
+		TEST(madvise(p, ALLOC_SIZE, MADV_WILLNEED));
+		if (TEST_RETURN == -1)
+			tst_brkm(TBROK | TTERRNO, cleanup, "madvise failed");
+		SAFE_MUNMAP(cleanup, p, ALLOC_SIZE);
+	}
+
+	tst_resm(TPASS, "issue has not been reproduced");
+
+	cleanup();
+	tst_exit();
+}
+
+static void setup(void)
+{
+	tst_sig(NOFORK, DEF_HANDLER, cleanup);
+	TEST_PAUSE;
+}
+
+static void cleanup(void)
+{
+	TEST_CLEANUP;
+}
-- 
1.7.1


------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] madvise05: new testcase for Oops in madvise_willneed

[chrubis]

Hi!
> This is a regression test for madvise(2) system call. It tests
> kernel for NULL ptr deref Oops fixed by:
>   commit ee53664bda169f519ce3c6a22d378f0b946c8178
>   Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>   Date:   Fri Dec 20 15:10:03 2013 +0200
>     mm: Fix NULL pointer dereference in madvise(MADV_WILLNEED) support

Looks good to me.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] madvise05: new testcase for Oops in madvise_willneed

[Caspar Zhang]

On 08/05/2014 10:45 PM, Jan Stancek wrote:
> This is a regression test for madvise(2) system call. It tests
> kernel for NULL ptr deref Oops fixed by:
>    commit ee53664bda169f519ce3c6a22d378f0b946c8178
>    Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>    Date:   Fri Dec 20 15:10:03 2013 +0200
>      mm: Fix NULL pointer dereference in madvise(MADV_WILLNEED) support
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
>   runtest/syscalls                              |    1 +
>   testcases/kernel/syscalls/.gitignore          |    1 +
>   testcases/kernel/syscalls/madvise/madvise05.c |   81 +++++++++++++++++++++++++
>   3 files changed, 83 insertions(+), 0 deletions(-)
>   create mode 100644 testcases/kernel/syscalls/madvise/madvise05.c
>
> diff --git a/runtest/syscalls b/runtest/syscalls
> index 5e6e0f4..142c350 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -715,6 +715,7 @@ madvise01 madvise01
>   madvise02 madvise02
>   madvise03 madvise03
>   madvise04 madvise04
> +madvise05 madvise05
>
>   newuname01 newuname01
>
> diff --git a/testcases/kernel/syscalls/.gitignore b/testcases/kernel/syscalls/.gitignore
> index fb2425e..fd52217 100644
> --- a/testcases/kernel/syscalls/.gitignore
> +++ b/testcases/kernel/syscalls/.gitignore
> @@ -479,6 +479,7 @@
>   /madvise/madvise02
>   /madvise/madvise03
>   /madvise/madvise04
> +/madvise/madvise05
>   /mallopt/mallopt01
>   /mbind/mbind01
>   /memcmp/memcmp01
> diff --git a/testcases/kernel/syscalls/madvise/madvise05.c b/testcases/kernel/syscalls/madvise/madvise05.c
> new file mode 100644
> index 0000000..043eb4d
> --- /dev/null
> +++ b/testcases/kernel/syscalls/madvise/madvise05.c
> @@ -0,0 +1,81 @@
> +/*
> + *  Copyright (c) Linux Test Project, 2014
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU Library General Public License for more details.
> + */
> +/*
> + * This is a regression test for madvise(2) system call. It tests kernel
> + * for NULL ptr deref Oops fixed by:
> + *   commit ee53664bda169f519ce3c6a22d378f0b946c8178
> + *   Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> + *   Date:   Fri Dec 20 15:10:03 2013 +0200
> + *     mm: Fix NULL pointer dereference in madvise(MADV_WILLNEED) support
> + *
> + * On buggy kernel with CONFIG_DEBUG_LOCK_ALLOC=y this testcase should
> + * produce Oops and/or be killed. On fixed/good kernel this testcase
> + * runs to completion (retcode is 0)
> + */
> +
> +#include <sys/mman.h>
> +#include <errno.h>
> +
> +#include "test.h"
> +#include "usctest.h"
> +#include "safe_macros.h"
> +
> +#define ALLOC_SIZE (32 * 1024 * 1024)
> +
> +static void setup(void);
> +static void cleanup(void);
> +
> +char *TCID = "madvise05";
> +int TST_TOTAL = 1;
> +
> +int main(int argc, char *argv[])
> +{
> +	int lc;
> +	const char *msg = NULL;
> +	void *p;
> +
> +	msg = parse_opts(argc, argv, NULL, NULL);
> +	if (msg)
> +		tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> +
> +	setup();
> +
> +	for (lc = 0; TEST_LOOPING(lc); lc++) {
> +		p = SAFE_MMAP(cleanup, NULL, ALLOC_SIZE, PROT_READ,
> +			MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0);
> +		TEST(mprotect(p, ALLOC_SIZE, PROT_NONE));
> +		if (TEST_RETURN == -1)
> +			tst_brkm(TBROK | TTERRNO, cleanup, "mprotect failed");
> +		TEST(madvise(p, ALLOC_SIZE, MADV_WILLNEED));
> +		if (TEST_RETURN == -1)
> +			tst_brkm(TBROK | TTERRNO, cleanup, "madvise failed");
> +		SAFE_MUNMAP(cleanup, p, ALLOC_SIZE);
> +	}
> +
> +	tst_resm(TPASS, "issue has not been reproduced");
> +
> +	cleanup();
> +	tst_exit();
> +}
> +
> +static void setup(void)
> +{
> +	tst_sig(NOFORK, DEF_HANDLER, cleanup);
> +	TEST_PAUSE;
> +}
> +
> +static void cleanup(void)
> +{
> +	TEST_CLEANUP;
> +}
>
Is MADV_WILLNEED available on all releases? If yes, the new case looks 
good to me.

Thanks,
Caspar

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] madvise05: new testcase for Oops in madvise_willneed

[Jan Stancek]

----- Original Message -----
> From: "Caspar Zhang" <caspar@casparzhang.com>
> To: "Jan Stancek" <jstancek@redhat.com>, ltp-list@lists.sourceforge.net
> Sent: Tuesday, 5 August, 2014 7:53:07 PM
> Subject: Re: [LTP] [PATCH] madvise05: new testcase for Oops in madvise_willneed
> 
> On 08/05/2014 10:45 PM, Jan Stancek wrote:
> > This is a regression test for madvise(2) system call. It tests
> > kernel for NULL ptr deref Oops fixed by:
> >    commit ee53664bda169f519ce3c6a22d378f0b946c8178
> >    Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> >    Date:   Fri Dec 20 15:10:03 2013 +0200
> >      mm: Fix NULL pointer dereference in madvise(MADV_WILLNEED) support
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> > ---
> >   runtest/syscalls                              |    1 +
> >   testcases/kernel/syscalls/.gitignore          |    1 +
> >   testcases/kernel/syscalls/madvise/madvise05.c |   81
> >   +++++++++++++++++++++++++
> >   3 files changed, 83 insertions(+), 0 deletions(-)
> >   create mode 100644 testcases/kernel/syscalls/madvise/madvise05.c
> >

> Is MADV_WILLNEED available on all releases? If yes, the new case looks
> good to me.

It was introduced before 2.4, so I assume it's available on releases
made after 2002. Also none of other madvise testcases checks/tests for it.

However, I noticed that older kernels fail with EBADF, if there is no
backing file. I'll fix that and send v2.

Regards,
Jan


------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list