Re: [LTP] [PATCH 2/3] cpuset/cpuset_syscall_test: check HAVE_DECL_MPOL_F_MEMS_ALLOWED

[Shuang Qiu <shuang.qiu@oracle.com>]

Hi Jan,

In this case,if MPOL_F_MEMS_ALLOWED is undeclared,"ret = -1" will make 
some of cpuset_syscall_test failed.
i.e. test15 failed: cpuset_syscall 15 TFAIL : Test task exited 
abnormally.(expect return value is 0)
Why do we fail this test if MPOL_F_MEMS_ALLOWED is undeclared rather 
than skip this test.

Thanks
Shuang
On 01/07/2014 09:46 PM, Jan Stancek wrote:
> This is to fix compilation on RHEL5.3:
>    gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -D_FORTIFY_SOURCE=2
>    -I/root/ltp/testcases/kernel/include -DNUMA_VERSION1_COMPATIBILITY
>    -I../../../../../include -I../../../../../include
>    -L/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib
>    -L/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../../libcontrollers
>    -L../../../../../lib  cpuset_syscall_test.c   -lltp -lcpu_set
>    -lcontrollers -lltp -lnuma -o cpuset_syscall_test
>    cpuset_syscall_test.c: In function ‘test_get_mempolicy’:
>    cpuset_syscall_test.c:190: error: ‘MPOL_F_MEMS_ALLOWED’ undeclared
>    (first use in this function)
>    cpuset_syscall_test.c:190: error: (Each undeclared identifier is
>    reported only once
>    cpuset_syscall_test.c:190: error: for each function it appears in.)
>    make[5]: *** [cpuset_syscall_test] Error 1
>
> This patch restores check which has been removed by this commit:
>    commit 87156a05a2ffd50f5e467d6f986daae9da7b9cf7
>    Author: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
>    Date:   Tue Oct 1 17:44:50 2013 +0400
>      cpuset/cpuset_syscall_test: fixes
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
>   .../cpuset_syscall_test/cpuset_syscall_test.c      |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c
> index dd35cd0..e202295 100644
> --- a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c
> +++ b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c
> @@ -186,8 +186,12 @@ void test_get_mempolicy(void)
>   		ret = 1;
>   		return;
>   	}
> +#if HAVE_DECL_MPOL_F_MEMS_ALLOWED
>   	ret = get_mempolicy(NULL, bitmask_mask(nmask), bitmask_nbits(nmask), 0,
>   			    MPOL_F_MEMS_ALLOWED);
> +#else
> +	ret = -1;
> +#endif
>   
>   	bitmask_displaylist(str, 256, nmask);
>   	puts(str);


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list