Re: [LTP] [PATCH v3 1/3] fcntl16: Skip fcntl16 tests on NFS

[Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>]

Hi!

On 08/21/2014 08:12 AM, Xiong Zhou wrote:
>
> According to nfs(5), NLM supports advisory file locks only. So skip
> fcntl16 test if NFS.
>

I've just took a fresh look at fcntl16.c and found that block1  of this 
test case may be executed on NFS. And, IMHO, this block1 test case is 
not 100% implemented by other fcntl*.c tests.

So I think that it will be more correct to have only block2, block3 skipped.

Sorry. I had to figure it out at the first time. :(

Thank you.

PS: And you pointed me one interesting issue.

The patch:

commit 5387ba03ce8eaddc7ec330ed03e579eed92596cc
Author: subrata_modak <subrata_modak>
Date:   Mon May 5 08:49:34 2008 +0000

     These test cases fail on the NFS environment due to NFS relates 
issue(s). Hence abondon these tests when NFS is detected. By, Sridhar 
Vinay <vinaysridhar@in.ibm.com>.

disabled entire tests and not particular test cases. And I think it's 
not quite correct, because some of the test cases may be executed on NFS.

For example, fcntl14.c has 4 test blocks, and only one of them doesn't 
work with NFS - block2 (mandatory locking).

Reviewing/fixing other fcntl*.c test cases looks like a useful activity. 
But for a later time :)


> Signed-off-by: Xiong Zhou <xzhou@redhat.com>
> ---
>   testcases/kernel/syscalls/fcntl/fcntl16.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/fcntl/fcntl16.c b/testcases/kernel/syscalls/fcntl/fcntl16.c
> index 44b6a80..7dba6ea 100644
> --- a/testcases/kernel/syscalls/fcntl/fcntl16.c
> +++ b/testcases/kernel/syscalls/fcntl/fcntl16.c
> @@ -51,6 +51,8 @@
>   #include <sys/types.h>
>   #include <sys/wait.h>
>
> +#include "tst_fs_type.h"
> +
>   #define SKIPVAL 0x0f00
>   //#define       SKIP    SKIPVAL, 0, 0L, 0L, IGNORED
>   #define SKIP 0,0,0L,0L,0
> @@ -412,6 +414,12 @@ void setup(void)
>
>   	tst_tmpdir();
>
> +	/* On NFS or not */
> +	if (tst_fs_type(cleanup, ".") == TST_NFS_MAGIC) {
> +		tst_brkm(TCONF, cleanup, "Cannot test madatory locking "
> +			"on a file located on an NFS filesystem");
> +	}
> +
>   	/* set up temp filename */
>   	sprintf(tmpname, "fcntl4.%d", parent);
>
>

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list