Re: [LTP] [PATCH 3/3] splice01/tee01/utime: test back on NFS

[Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>]

Hi!

On 09/11/2014 02:32 PM, Xiong Zhou wrote:
> NFS support splice(2) tee(2) and utime(2) now.

I think that 'now' is a bit relative. I.e. for me 'now'
can be 2.6.39, but for another guy - 3.16.2 or whatever.

My proposal:
  * if this support came many-many years ago, we just mark the fact in 
the description
  * if this support came recently, we have to add a kernel check in the 
tests


>
> Signed-off-by: Xiong Zhou <xzhou@redhat.com>
> ---
>   testcases/kernel/syscalls/splice/splice01.c | 5 -----
>   testcases/kernel/syscalls/tee/tee01.c       | 5 -----
>   testcases/kernel/syscalls/utime/utime01.c   | 1 -
>   testcases/kernel/syscalls/utime/utime02.c   | 1 -
>   testcases/kernel/syscalls/utime/utime03.c   | 1 -
>   5 files changed, 13 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/splice/splice01.c b/testcases/kernel/syscalls/splice/splice01.c
> index e96ff6d..7bd53b8 100644
> --- a/testcases/kernel/syscalls/splice/splice01.c
> +++ b/testcases/kernel/syscalls/splice/splice01.c
> @@ -134,11 +134,6 @@ static void setup(void)
>
>   	tst_tmpdir();
>
> -	if (tst_fs_type(cleanup, ".") == TST_NFS_MAGIC) {
> -		tst_brkm(TCONF, cleanup,
> -			 "Cannot do splice on a file on NFS filesystem");
> -	}
> -
>   	for (i = 0; i < TEST_BLOCK_SIZE; i++)
>   		buffer[i] = i & 0xff;
>
> diff --git a/testcases/kernel/syscalls/tee/tee01.c b/testcases/kernel/syscalls/tee/tee01.c
> index 6ea6f18..f87df5d 100644
> --- a/testcases/kernel/syscalls/tee/tee01.c
> +++ b/testcases/kernel/syscalls/tee/tee01.c
> @@ -146,11 +146,6 @@ static void setup(void)
>
>   	tst_tmpdir();
>
> -	if (tst_fs_type(cleanup, ".") == TST_NFS_MAGIC) {
> -		tst_brkm(TCONF, cleanup,
> -			 "Cannot do tee on a file on NFS filesystem");
> -	}
> -
>   	for (i = 0; i < TEST_BLOCK_SIZE; i++)
>   		buffer[i] = i & 0xff;
>
> diff --git a/testcases/kernel/syscalls/utime/utime01.c b/testcases/kernel/syscalls/utime/utime01.c
> index 3128965..4c41bc7 100644
> --- a/testcases/kernel/syscalls/utime/utime01.c
> +++ b/testcases/kernel/syscalls/utime/utime01.c
> @@ -114,7 +114,6 @@ int main(int ac, char **av)
>   	setup();
>
>   	switch ((type = tst_fs_type(cleanup, "."))) {
> -	case TST_NFS_MAGIC:
>   	case TST_V9FS_MAGIC:
>   		tst_brkm(TCONF, cleanup,
>   			 "Cannot do utime on a file on %s filesystem",
> diff --git a/testcases/kernel/syscalls/utime/utime02.c b/testcases/kernel/syscalls/utime/utime02.c
> index cbd30da..6624695 100644
> --- a/testcases/kernel/syscalls/utime/utime02.c
> +++ b/testcases/kernel/syscalls/utime/utime02.c
> @@ -120,7 +120,6 @@ int main(int ac, char **av)
>   	setup();
>
>   	switch ((type = tst_fs_type(cleanup, "."))) {
> -	case TST_NFS_MAGIC:
>   	case TST_V9FS_MAGIC:
>   		tst_brkm(TCONF, cleanup,
>   			 "Cannot do utime on a file on %s filesystem",
> diff --git a/testcases/kernel/syscalls/utime/utime03.c b/testcases/kernel/syscalls/utime/utime03.c
> index 858f6ca..32b0d29 100644
> --- a/testcases/kernel/syscalls/utime/utime03.c
> +++ b/testcases/kernel/syscalls/utime/utime03.c
> @@ -130,7 +130,6 @@ int main(int ac, char **av)
>   	setup();
>
>   	switch ((type = tst_fs_type(cleanup, "."))) {
> -	case TST_NFS_MAGIC:
>   	case TST_V9FS_MAGIC:
>   		tst_brkm(TCONF, cleanup,
>   			 "Cannot do utime on a file on %s filesystem",
>

------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list