From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH v2 1/2] network ftp: some cleanup
Date: Thu, 25 Sep 2014 14:56:08 +0400 [thread overview]
Message-ID: <5423F4C8.10101@oracle.com> (raw)
In-Reply-To: <53DB94E1.70404@oracle.com>
Hi!
On 08/01/2014 05:23 PM, Alexey Kodanev wrote:
> Hi Zeng!
> On 08/01/2014 07:11 AM, Zeng Linggang wrote:
>> * Move do_setup and do_cleanup into ftp_setup.
>>
>> * Delete ftp02_s1 and add do_test function for it.
>>
>> * Delete ftp_set_passwd and ftp_setup_vsftp_conf, since they are not
>> be used.
>>
>> * Use test.sh instead of net_cmdlib.sh
>>
>> * Abandon trap and use tst_exit.
>>
>> * Make the test like:
>> (set TCID TST_TOTAL ...)
>> setup
>> do_test
>> check_result
>> tst_exit
>>
>> * Some cleanup.
>>
>> Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
>> ---
>> testcases/network/tcp_cmds/ftp/ftp02 | 99 +++++++-----
>> testcases/network/tcp_cmds/ftp/ftp02_s1 | 71 ---------
>> testcases/network/tcp_cmds/ftp/ftp03 | 175
>> +++++++--------------
>> testcases/network/tcp_cmds/ftp/ftp04 | 109 ++++++-------
>> testcases/network/tcp_cmds/ftp/ftp05 | 146
>> ++++++++---------
>> testcases/network/tcp_cmds/ftp/ftp_set_passwd | 28 ----
>> testcases/network/tcp_cmds/ftp/ftp_setup | 73 +++++++++
>> .../network/tcp_cmds/ftp/ftp_setup_vsftp_conf | 5 -
>> 8 files changed, 304 insertions(+), 402 deletions(-)
>> delete mode 100755 testcases/network/tcp_cmds/ftp/ftp02_s1
>> delete mode 100755 testcases/network/tcp_cmds/ftp/ftp_set_passwd
>> create mode 100644 testcases/network/tcp_cmds/ftp/ftp_setup
>> delete mode 100755 testcases/network/tcp_cmds/ftp/ftp_setup_vsftp_conf
>>
...
>> -#-----------------------------------------------------------------------
>> -# FUNCTION: do_cleanup
>> -#-----------------------------------------------------------------------
>>
>> +TCID="$0"
>
> May be we should just change it to ftp02, otherwise test name will
> depend on how you running it (e.g. running by full path, TCID becomes
> "/opt/ltp/testcases/bin/test_name".
>
Pushed both patches, also changed TCID names.
Thanks.
> Are you running these tests from runEALtests.sh?
>
> Can we add them to networktests.sh, to "TCP/IP command tests" group as
> it already has ftp01?
>
> Thanks,
> Alexey
>
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-09-25 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 11:42 [LTP] [PATCH 1/2] network ftp: some cleanup Zeng Linggang
2014-07-29 11:42 ` [LTP] [PATCH 2/2] network ssh: " Zeng Linggang
2014-07-31 11:55 ` [LTP] [PATCH 1/2] network ftp: " Alexey
2014-08-01 1:25 ` Zeng Linggang
2014-08-01 3:11 ` [LTP] [PATCH v2 " Zeng Linggang
2014-08-01 13:23 ` Alexey Kodanev
2014-09-25 10:56 ` Alexey Kodanev [this message]
2014-08-01 3:12 ` [LTP] [PATCH v2 2/2] network ssh: " Zeng Linggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5423F4C8.10101@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=zenglg.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox