From: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
To: Zorro Lang <zlang@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
Date: Tue, 14 Oct 2014 10:55:00 +0800 [thread overview]
Message-ID: <543C9084.6070501@cn.fujitsu.com> (raw)
In-Reply-To: <1413212682-13117-1-git-send-email-zlang@redhat.com>
Hi,
On 10/13/2014 11:04 PM, Zorro Lang wrote:
> ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
> That cause other cases which use ext4_get_inode_version.sh to fail.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
>
> Hi,
>
> When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
> Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
> ext4_get_inode_version.sh use $EXT4_DEV ->
> but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
Yeah, this is a bug :)
>
> About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
> But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
I think adding "export EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh would be better.
Regards,
Xiaoguang Wang
>
> Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
>
> Thank you,
> Zorro Lang
>
> .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
> index ac8f021..2549088 100755
> --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
> +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
> @@ -138,6 +138,8 @@ test_inode_version()
>
> # main
> ext4_setup
> +# export EXT4_DEV for ext4_get_inode_version.sh can know it
> +export EXT4_DEV=$EXT4_DEV
>
> ext4_test_128_inode_version
>
>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-10-14 2:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 15:04 [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition Zorro Lang
2014-10-14 2:55 ` Xiaoguang Wang [this message]
2014-10-14 11:30 ` Zorro Lang
2014-10-15 3:35 ` Xiaoguang Wang
2014-10-15 6:13 ` Zorro Lang
2014-10-15 8:12 ` Wanlong Gao
2014-10-22 10:31 ` Zirong Lang
2014-10-22 12:33 ` Wanlong Gao
-- strict thread matches above, loose matches on Subject: below --
2014-10-01 14:32 Zorro Lang
2014-09-30 16:13 Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543C9084.6070501@cn.fujitsu.com \
--to=wangxg.fnst@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox