* [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
@ 2014-10-13 15:04 Zorro Lang
2014-10-14 2:55 ` Xiaoguang Wang
0 siblings, 1 reply; 10+ messages in thread
From: Zorro Lang @ 2014-10-13 15:04 UTC (permalink / raw)
To: ltp-list
ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
That cause other cases which use ext4_get_inode_version.sh to fail.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
Hi,
When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
ext4_get_inode_version.sh use $EXT4_DEV ->
but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
Thank you,
Zorro Lang
.../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
index ac8f021..2549088 100755
--- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
+++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
@@ -138,6 +138,8 @@ test_inode_version()
# main
ext4_setup
+# export EXT4_DEV for ext4_get_inode_version.sh can know it
+export EXT4_DEV=$EXT4_DEV
ext4_test_128_inode_version
--
1.9.3
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
2014-10-13 15:04 [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition Zorro Lang
@ 2014-10-14 2:55 ` Xiaoguang Wang
2014-10-14 11:30 ` Zorro Lang
0 siblings, 1 reply; 10+ messages in thread
From: Xiaoguang Wang @ 2014-10-14 2:55 UTC (permalink / raw)
To: Zorro Lang; +Cc: ltp-list
Hi,
On 10/13/2014 11:04 PM, Zorro Lang wrote:
> ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
> That cause other cases which use ext4_get_inode_version.sh to fail.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
>
> Hi,
>
> When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
> Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
> ext4_get_inode_version.sh use $EXT4_DEV ->
> but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
Yeah, this is a bug :)
>
> About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
> But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
I think adding "export EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh would be better.
Regards,
Xiaoguang Wang
>
> Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
>
> Thank you,
> Zorro Lang
>
> .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
> index ac8f021..2549088 100755
> --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
> +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
> @@ -138,6 +138,8 @@ test_inode_version()
>
> # main
> ext4_setup
> +# export EXT4_DEV for ext4_get_inode_version.sh can know it
> +export EXT4_DEV=$EXT4_DEV
>
> ext4_test_128_inode_version
>
>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
2014-10-14 2:55 ` Xiaoguang Wang
@ 2014-10-14 11:30 ` Zorro Lang
2014-10-15 3:35 ` Xiaoguang Wang
2014-10-15 8:12 ` Wanlong Gao
0 siblings, 2 replies; 10+ messages in thread
From: Zorro Lang @ 2014-10-14 11:30 UTC (permalink / raw)
To: Xiaoguang Wang; +Cc: ltp-list
在 2014年10月14日 10:55, Xiaoguang Wang 写道:
> Hi,
>
> On 10/13/2014 11:04 PM, Zorro Lang wrote:
>> ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
>> That cause other cases which use ext4_get_inode_version.sh to fail.
>>
>> Signed-off-by: Zorro Lang <zlang@redhat.com>
>> ---
>>
>> Hi,
>>
>> When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
>> Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
>> ext4_get_inode_version.sh use $EXT4_DEV ->
>> but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
> Yeah, this is a bug :)
>> About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
>> But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
> I think adding "export EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh would be better.
Hi xiaoguang,
Do you mean patch likes below is better?
diff --git a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
index 0ae534a..b51e942 100755
--- a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
+++ b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
@@ -45,7 +45,7 @@ ext4_setup()
if [ -z "$LTP_BIG_DEV" ];then
tst_brkm TCONF "tests need a big block device(5G-10G)"
else
- EXT4_DEV=$LTP_BIG_DEV
+ export EXT4_DEV=$LTP_BIG_DEV
fi
tst_tmpdir
If you want to merge this patch, I will resend it as the better way.
Thank you,
Zorro Lang
>
> Regards,
> Xiaoguang Wang
>
>> Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
>>
>> Thank you,
>> Zorro Lang
>>
>> .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>> index ac8f021..2549088 100755
>> --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>> +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>> @@ -138,6 +138,8 @@ test_inode_version()
>>
>> # main
>> ext4_setup
>> +# export EXT4_DEV for ext4_get_inode_version.sh can know it
>> +export EXT4_DEV=$EXT4_DEV
>>
>> ext4_test_128_inode_version
>>
>>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
2014-10-14 11:30 ` Zorro Lang
@ 2014-10-15 3:35 ` Xiaoguang Wang
2014-10-15 6:13 ` Zorro Lang
2014-10-15 8:12 ` Wanlong Gao
1 sibling, 1 reply; 10+ messages in thread
From: Xiaoguang Wang @ 2014-10-15 3:35 UTC (permalink / raw)
To: Zorro Lang; +Cc: ltp-list
Hi,
On 10/14/2014 07:30 PM, Zorro Lang wrote:
> 在 2014年10月14日 10:55, Xiaoguang Wang 写道:
>> Hi,
>>
>> On 10/13/2014 11:04 PM, Zorro Lang wrote:
>>> ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
>>> That cause other cases which use ext4_get_inode_version.sh to fail.
>>>
>>> Signed-off-by: Zorro Lang <zlang@redhat.com>
>>> ---
>>>
>>> Hi,
>>>
>>> When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
>>> Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
>>> ext4_get_inode_version.sh use $EXT4_DEV ->
>>> but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
>> Yeah, this is a bug :)
>>> About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
>>> But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
>> I think adding "export EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh would be better.
> Hi xiaoguang,
>
> Do you mean patch likes below is better?
Yeah, it looks good to me.
I'm not a maintainer :)
Regards,
Xiaoguang Wang
>
> diff --git a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> index 0ae534a..b51e942 100755
> --- a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> +++ b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> @@ -45,7 +45,7 @@ ext4_setup()
> if [ -z "$LTP_BIG_DEV" ];then
> tst_brkm TCONF "tests need a big block device(5G-10G)"
> else
> - EXT4_DEV=$LTP_BIG_DEV
> + export EXT4_DEV=$LTP_BIG_DEV
> fi
>
> tst_tmpdir
>
>
> If you want to merge this patch, I will resend it as the better way.
>
> Thank you,
> Zorro Lang
>>
>> Regards,
>> Xiaoguang Wang
>>
>>> Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
>>>
>>> Thank you,
>>> Zorro Lang
>>>
>>> .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>> index ac8f021..2549088 100755
>>> --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>> +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>> @@ -138,6 +138,8 @@ test_inode_version()
>>> # main
>>> ext4_setup
>>> +# export EXT4_DEV for ext4_get_inode_version.sh can know it
>>> +export EXT4_DEV=$EXT4_DEV
>>> ext4_test_128_inode_version
>>>
>
> .
>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
2014-10-15 3:35 ` Xiaoguang Wang
@ 2014-10-15 6:13 ` Zorro Lang
0 siblings, 0 replies; 10+ messages in thread
From: Zorro Lang @ 2014-10-15 6:13 UTC (permalink / raw)
To: ltp-list
在 2014年10月15日 11:35, Xiaoguang Wang 写道:
> Hi,
>
> On 10/14/2014 07:30 PM, Zorro Lang wrote:
>> 在 2014年10月14日 10:55, Xiaoguang Wang 写道:
>>> Hi,
>>>
>>> On 10/13/2014 11:04 PM, Zorro Lang wrote:
>>>> ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
>>>> That cause other cases which use ext4_get_inode_version.sh to fail.
>>>>
>>>> Signed-off-by: Zorro Lang <zlang@redhat.com>
>>>> ---
>>>>
>>>> Hi,
>>>>
>>>> When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
>>>> Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
>>>> ext4_get_inode_version.sh use $EXT4_DEV ->
>>>> but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
>>> Yeah, this is a bug :)
>>>> About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
>>>> But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
>>> I think adding "export EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh would be better.
>> Hi xiaoguang,
>>
>> Do you mean patch likes below is better?
> Yeah, it looks good to me.
> I'm not a maintainer :)
>
> Regards,
> Xiaoguang Wang
Oh, still thanks for you;)
But I still need the review from maintainer. Anyone can help?
Thank you,
Zorro Lang
>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
>> index 0ae534a..b51e942 100755
>> --- a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
>> +++ b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
>> @@ -45,7 +45,7 @@ ext4_setup()
>> if [ -z "$LTP_BIG_DEV" ];then
>> tst_brkm TCONF "tests need a big block device(5G-10G)"
>> else
>> - EXT4_DEV=$LTP_BIG_DEV
>> + export EXT4_DEV=$LTP_BIG_DEV
>> fi
>>
>> tst_tmpdir
>>
>>
>> If you want to merge this patch, I will resend it as the better way.
>>
>> Thank you,
>> Zorro Lang
>>> Regards,
>>> Xiaoguang Wang
>>>
>>>> Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
>>>>
>>>> Thank you,
>>>> Zorro Lang
>>>>
>>>> .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>>> index ac8f021..2549088 100755
>>>> --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>>> +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>>> @@ -138,6 +138,8 @@ test_inode_version()
>>>> # main
>>>> ext4_setup
>>>> +# export EXT4_DEV for ext4_get_inode_version.sh can know it
>>>> +export EXT4_DEV=$EXT4_DEV
>>>> ext4_test_128_inode_version
>>>>
>> .
>>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
2014-10-14 11:30 ` Zorro Lang
2014-10-15 3:35 ` Xiaoguang Wang
@ 2014-10-15 8:12 ` Wanlong Gao
2014-10-22 10:31 ` Zirong Lang
1 sibling, 1 reply; 10+ messages in thread
From: Wanlong Gao @ 2014-10-15 8:12 UTC (permalink / raw)
To: Zorro Lang; +Cc: ltp-list
On 10/14/2014 07:30 PM, Zorro Lang wrote:
> 在 2014年10月14日 10:55, Xiaoguang Wang 写道:
>> Hi,
>>
>> On 10/13/2014 11:04 PM, Zorro Lang wrote:
>>> ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
>>> That cause other cases which use ext4_get_inode_version.sh to fail.
>>>
>>> Signed-off-by: Zorro Lang <zlang@redhat.com>
>>> ---
>>>
>>> Hi,
>>>
>>> When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
>>> Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
>>> ext4_get_inode_version.sh use $EXT4_DEV ->
>>> but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
>> Yeah, this is a bug :)
>>> About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
>>> But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
>> I think adding "export EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh would be better.
> Hi xiaoguang,
>
> Do you mean patch likes below is better?
>
> diff --git a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> index 0ae534a..b51e942 100755
> --- a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> +++ b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> @@ -45,7 +45,7 @@ ext4_setup()
> if [ -z "$LTP_BIG_DEV" ];then
> tst_brkm TCONF "tests need a big block device(5G-10G)"
> else
> - EXT4_DEV=$LTP_BIG_DEV
> + export EXT4_DEV=$LTP_BIG_DEV
Acked-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> fi
>
> tst_tmpdir
>
>
> If you want to merge this patch, I will resend it as the better way.
>
> Thank you,
> Zorro Lang
>>
>> Regards,
>> Xiaoguang Wang
>>
>>> Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
>>>
>>> Thank you,
>>> Zorro Lang
>>>
>>> .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>> index ac8f021..2549088 100755
>>> --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>> +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>> @@ -138,6 +138,8 @@ test_inode_version()
>>>
>>> # main
>>> ext4_setup
>>> +# export EXT4_DEV for ext4_get_inode_version.sh can know it
>>> +export EXT4_DEV=$EXT4_DEV
>>>
>>> ext4_test_128_inode_version
>>>
>>>
>
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
2014-10-15 8:12 ` Wanlong Gao
@ 2014-10-22 10:31 ` Zirong Lang
2014-10-22 12:33 ` Wanlong Gao
0 siblings, 1 reply; 10+ messages in thread
From: Zirong Lang @ 2014-10-22 10:31 UTC (permalink / raw)
To: gaowanlong; +Cc: ltp-list
Hi Wanlong Gao,
Thanks for your ACK. But I can't find this patch on upstream ltp repo until now.
Should I re-send the acked patch to you?
Thank you,
Zorro Lang
----- 原始邮件 -----
发件人: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
收件人: "Zorro Lang" <zlang@redhat.com>
抄送: "Xiaoguang Wang" <wangxg.fnst@cn.fujitsu.com>, ltp-list@lists.sourceforge.net
发送时间: 星期三, 2014年 10 月 15日 下午 4:12:11
主题: Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
On 10/14/2014 07:30 PM, Zorro Lang wrote:
> 在 2014年10月14日 10:55, Xiaoguang Wang 写道:
>> Hi,
>>
>> On 10/13/2014 11:04 PM, Zorro Lang wrote:
>>> ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
>>> That cause other cases which use ext4_get_inode_version.sh to fail.
>>>
>>> Signed-off-by: Zorro Lang <zlang@redhat.com>
>>> ---
>>>
>>> Hi,
>>>
>>> When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
>>> Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
>>> ext4_get_inode_version.sh use $EXT4_DEV ->
>>> but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
>> Yeah, this is a bug :)
>>> About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
>>> But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
>> I think adding "export EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh would be better.
> Hi xiaoguang,
>
> Do you mean patch likes below is better?
>
> diff --git a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> index 0ae534a..b51e942 100755
> --- a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> +++ b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
> @@ -45,7 +45,7 @@ ext4_setup()
> if [ -z "$LTP_BIG_DEV" ];then
> tst_brkm TCONF "tests need a big block device(5G-10G)"
> else
> - EXT4_DEV=$LTP_BIG_DEV
> + export EXT4_DEV=$LTP_BIG_DEV
Acked-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> fi
>
> tst_tmpdir
>
>
> If you want to merge this patch, I will resend it as the better way.
>
> Thank you,
> Zorro Lang
>>
>> Regards,
>> Xiaoguang Wang
>>
>>> Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
>>>
>>> Thank you,
>>> Zorro Lang
>>>
>>> .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>> index ac8f021..2549088 100755
>>> --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>> +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>> @@ -138,6 +138,8 @@ test_inode_version()
>>>
>>> # main
>>> ext4_setup
>>> +# export EXT4_DEV for ext4_get_inode_version.sh can know it
>>> +export EXT4_DEV=$EXT4_DEV
>>>
>>> ext4_test_128_inode_version
>>>
>>>
>
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
2014-10-22 10:31 ` Zirong Lang
@ 2014-10-22 12:33 ` Wanlong Gao
0 siblings, 0 replies; 10+ messages in thread
From: Wanlong Gao @ 2014-10-22 12:33 UTC (permalink / raw)
To: Zirong Lang; +Cc: ltp-list
On 10/22/2014 06:31 PM, Zirong Lang wrote:
> Hi Wanlong Gao,
>
> Thanks for your ACK. But I can't find this patch on upstream ltp repo until now.
> Should I re-send the acked patch to you?
Yeah, it's better to resend the patch to ML so that we can apply it easier,
thank you for your work.
Thanks,
Wanlong Gao
>
> Thank you,
> Zorro Lang
>
> ----- 原始邮件 -----
> 发件人: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
> 收件人: "Zorro Lang" <zlang@redhat.com>
> 抄送: "Xiaoguang Wang" <wangxg.fnst@cn.fujitsu.com>, ltp-list@lists.sourceforge.net
> 发送时间: 星期三, 2014年 10 月 15日 下午 4:12:11
> 主题: Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
>
> On 10/14/2014 07:30 PM, Zorro Lang wrote:
>> 在 2014年10月14日 10:55, Xiaoguang Wang 写道:
>>> Hi,
>>>
>>> On 10/13/2014 11:04 PM, Zorro Lang wrote:
>>>> ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
>>>> That cause other cases which use ext4_get_inode_version.sh to fail.
>>>>
>>>> Signed-off-by: Zorro Lang <zlang@redhat.com>
>>>> ---
>>>>
>>>> Hi,
>>>>
>>>> When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
>>>> Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
>>>> ext4_get_inode_version.sh use $EXT4_DEV ->
>>>> but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
>>> Yeah, this is a bug :)
>>>> About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
>>>> But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
>>> I think adding "export EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh would be better.
>> Hi xiaoguang,
>>
>> Do you mean patch likes below is better?
>>
>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
>> b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
>> index 0ae534a..b51e942 100755
>> --- a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
>> +++ b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
>> @@ -45,7 +45,7 @@ ext4_setup()
>> if [ -z "$LTP_BIG_DEV" ];then
>> tst_brkm TCONF "tests need a big block device(5G-10G)"
>> else
>> - EXT4_DEV=$LTP_BIG_DEV
>> + export EXT4_DEV=$LTP_BIG_DEV
>
> Acked-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
>> fi
>>
>> tst_tmpdir
>>
>>
>> If you want to merge this patch, I will resend it as the better way.
>>
>> Thank you,
>> Zorro Lang
>>>
>>> Regards,
>>> Xiaoguang Wang
>>>
>>>> Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
>>>>
>>>> Thank you,
>>>> Zorro Lang
>>>>
>>>> .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>>> index ac8f021..2549088 100755
>>>> --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>>> +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>>>> @@ -138,6 +138,8 @@ test_inode_version()
>>>>
>>>> # main
>>>> ext4_setup
>>>> +# export EXT4_DEV for ext4_get_inode_version.sh can know it
>>>> +export EXT4_DEV=$EXT4_DEV
>>>>
>>>> ext4_test_128_inode_version
>>>>
>>>>
>>
>>
>> ------------------------------------------------------------------------------
>> Comprehensive Server Monitoring with Site24x7.
>> Monitor 10 servers for $9/Month.
>> Get alerted through email, SMS, voice calls or mobile push notifications.
>> Take corrective actions from your mobile device.
>> http://p.sf.net/sfu/Zoho
>> _______________________________________________
>> Ltp-list mailing list
>> Ltp-list@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/ltp-list
>>
>
> .
>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 10+ messages in thread
* [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
@ 2014-10-01 14:32 Zorro Lang
0 siblings, 0 replies; 10+ messages in thread
From: Zorro Lang @ 2014-10-01 14:32 UTC (permalink / raw)
To: ltp-list
ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
That cause other cases which use ext4_get_inode_version.sh to fail.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
Hi,
When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
ext4_get_inode_version.sh use $EXT4_DEV ->
but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
Thank you,
Zorro Lang
.../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
index ac8f021..2549088 100755
--- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
+++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
@@ -138,6 +138,8 @@ test_inode_version()
# main
ext4_setup
+# export EXT4_DEV for ext4_get_inode_version.sh can know it
+export EXT4_DEV=$EXT4_DEV
ext4_test_128_inode_version
--
1.9.3
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition
@ 2014-09-30 16:13 Zorro Lang
0 siblings, 0 replies; 10+ messages in thread
From: Zorro Lang @ 2014-09-30 16:13 UTC (permalink / raw)
To: ltp-list
ext4_get_inode_version.sh use $EXT4_DEV, but it really don't known what is $EXT4_DEV.
That cause other cases which use ext4_get_inode_version.sh will failed.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
Hi,
When I run ext4-inode-version, I always hit TFAIL. But I can't reproduce the fail manually.
Then I find ext4_inode_version_test.sh use ext4_get_inode_version.sh, ext4_get_inode_version.sh
$EXT4_DEV which ext4_get_inode_version.sh don't know what it is.
About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it use ext4_get_inode_version.sh.
But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
Thank you,
Zorro Lang
.../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
index ac8f021..2549088 100755
--- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
+++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
@@ -138,6 +138,8 @@ test_inode_version()
# main
ext4_setup
+# export EXT4_DEV for ext4_get_inode_version.sh can know it
+export EXT4_DEV=$EXT4_DEV
ext4_test_128_inode_version
--
1.9.3
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-10-22 12:33 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-13 15:04 [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition Zorro Lang
2014-10-14 2:55 ` Xiaoguang Wang
2014-10-14 11:30 ` Zorro Lang
2014-10-15 3:35 ` Xiaoguang Wang
2014-10-15 6:13 ` Zorro Lang
2014-10-15 8:12 ` Wanlong Gao
2014-10-22 10:31 ` Zirong Lang
2014-10-22 12:33 ` Wanlong Gao
-- strict thread matches above, loose matches on Subject: below --
2014-10-01 14:32 Zorro Lang
2014-09-30 16:13 Zorro Lang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox