Re: [LTP] [PATCH 1/3] network/test_net: add support for -6 option (IPv6 tests)

[Alexey Kodanev <alexey.kodanev@oracle.com>]

Hi,
On 10/09/2014 05:24 PM, Hangbin Liu wrote:
> Ah, find your patch here :)
>
> Just as you said, net_cmdlib.sh source cmdlib.sh, so how about do it like
> test.sh, add a global variable $CMD_LIB_LOADED in cmdlib.sh and add
>
> [ -z "$CMD_LIB_LOADED" ] && . cmdlib.sh
>
> in test_net.sh ?

No, we shouldn't use obsolete 'cmdlib.sh' and new 'test.sh' together.

> For function read_opts(), I greped ltp and only found tests under tcp_cmds use
> it. So I think it's OK to change all net_cmdlib.sh directly. But as your wish,
> you can send it separately, not a big deal.

It's preferably to additionally replace outdated interface with the new 
one when tests need some fixes. Inevitably, the tests become fixed and 
easy to support in the future, confirm with the latest suite standards 
(e.g. test output, return exit codes).
That's why when I said that patches should be sent separately I also 
meant the replacement of cmdlib.sh as well. Otherwise I don't see any 
reason to replace just read_opts with identical one from another file.

Thanks,
Alexey


------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list