Re: [LTP] [PATCH] ext4-new-features: modify ext4_get_inode_version.sh not know $EXT4_DEV definition

Zorro Lang
2014-10-14T11:31:02Z

在 2014年10月14日 10:55, Xiaoguang Wang 写道:
> Hi,
>
> On 10/13/2014 11:04 PM, Zorro Lang wrote:
>> ext4_get_inode_version.sh use $EXT4_DEV, but it really doesn't know what is $EXT4_DEV.
>> That cause other cases which use ext4_get_inode_version.sh to fail.
>>
>> Signed-off-by: Zorro Lang <zlang@redhat.com>
>> ---
>>
>> Hi,
>>
>> When I ran ext4-inode-version, I always hit TFAIL. But I can't reproduce the failure manually.
>> Then I found ext4_inode_version_test.sh use ext4_get_inode_version.sh ->
>> ext4_get_inode_version.sh use $EXT4_DEV ->
>> but ext4_get_inode_version.sh doesn't know what is $EXT4_DEV.
> Yeah, this is a bug :)
>> About this patch, I export $EXT4_DEV in ext4_inode_version_test.sh, before it call ext4_get_inode_version.sh.
>> But I think add the "export" in front of "EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh will be another method.
> I think adding "export EXT4_DEV=$LTP_BIG_DEV" in ext4_funcs.sh would be better.
Hi xiaoguang,

Do you mean patch likes below is better?

diff --git a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
index 0ae534a..b51e942 100755
--- a/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
+++ b/testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
@@ -45,7 +45,7 @@ ext4_setup()
if [ -z "$LTP_BIG_DEV" ];then
tst_brkm TCONF "tests need a big block device(5G-10G)"
else
- EXT4_DEV=$LTP_BIG_DEV
+ export EXT4_DEV=$LTP_BIG_DEV
fi

tst_tmpdir

If you want to merge this patch, I will resend it as the better way.

Thank you,
Zorro Lang
>
> Regards,
> Xiaoguang Wang
>
>> Please review, and tell me which one do you think is better for LTP? Or you have a better one;)
>>
>> Thank you,
>> Zorro Lang
>>
>> .../fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>> index ac8f021..2549088 100755
>> --- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>> +++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
>> @@ -138,6 +138,8 @@ test_inode_version()
>>
>> # main
>> ext4_setup
>> +# export EXT4_DEV for ext4_get_inode_version.sh can know it
>> +export EXT4_DEV=$EXT4_DEV
>>
>> ext4_test_128_inode_version