Re: [LTP] [PATCH v2 2/2] syscalls/mmap16: regression test for data corruption when blocksize < pagesize for mmaped data

[Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>]

Hi,

On 02/06/2015 03:09 PM, Li Wang wrote:
> Hi,
> 
> I found there are two new LTP changes have been applied, which would be
> probably impact to your case:
> commit aabb8340f63ed31afe995fd97795e542dc68b93c
>     Include usctest.h in test.h
> commit 605fa3362fd7cef0baa2131be32cf44661783d3e
>     Get rid of TEST_CLEANUP
> 
> Seems we should remove two lines of the testcase as below otherwise it 
> can't be compile.

OK, thanks!
I'll send V3 next Monday, in case somebody has other comments ;)
> 
> BTW, I tested it on patched kernel it can works well and Bug reproduced
> with unpatched kernel.
Thanks!

Regards,
Xiaoguang Wang
> 
> Thanks,
> Li Wang
> 
> On Wed, 2015-02-04 at 16:59 +0800, Xiaoguang Wang wrote:
>> This data corruption fixed by:
> ...
>> +
>> +#include <stdio.h>
>> +#include <errno.h>
>> +#include <fcntl.h>
>> +#include <sys/types.h>
>> +#include <sys/wait.h>
>> +#include <unistd.h>
>> +#include <sys/mount.h>
>> +#include <sys/mman.h>
>> +
>> +#include "usctest.h"    <=========== remove 
>> +#include "test.h"
>> +#include "safe_macros.h"
>> +
>> +#define MNTPOINT	"mntpoint"
>> +#define FS_BLOCKSIZE	1024
> ...
>> +
>> +static void cleanup(void)
>> +{
>> +	TEST_CLEANUP;   <============ remove
>> +
>> +	if (chdir(".."))
>> +		tst_resm(TWARN | TERRNO, "chdir('..') failed");
>> +	if (mount_flag && tst_umount(MNTPOINT) < 0)
>> +		tst_resm(TWARN | TERRNO, "umount device:%s failed", device);
>> +	if (device)
>> +		tst_release_device(NULL, device);
>> +	tst_rmdir();
>> +}
> 
> .
> 


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list