From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1YJdBf-0005rn-RA for ltp-list@lists.sourceforge.net; Fri, 06 Feb 2015 07:18:47 +0000 Received: from [59.151.112.132] (helo=heian.cn.fujitsu.com) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1YJdBe-00064Y-MP for ltp-list@lists.sourceforge.net; Fri, 06 Feb 2015 07:18:47 +0000 Message-ID: <54D46997.6050704@cn.fujitsu.com> Date: Fri, 6 Feb 2015 15:13:27 +0800 From: Xiaoguang Wang MIME-Version: 1.0 References: <20150203095709.GB15330@rei.scz.novell.com> <1423040387-2029-1-git-send-email-wangxg.fnst@cn.fujitsu.com> <1423040387-2029-2-git-send-email-wangxg.fnst@cn.fujitsu.com> <1423206548.27888.29.camel@dhcp-13-206.nay.redhat.com> In-Reply-To: <1423206548.27888.29.camel@dhcp-13-206.nay.redhat.com> Subject: Re: [LTP] [PATCH v2 2/2] syscalls/mmap16: regression test for data corruption when blocksize < pagesize for mmaped data List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Li Wang Cc: ltp-list@lists.sourceforge.net Hi, On 02/06/2015 03:09 PM, Li Wang wrote: > Hi, > > I found there are two new LTP changes have been applied, which would be > probably impact to your case: > commit aabb8340f63ed31afe995fd97795e542dc68b93c > Include usctest.h in test.h > commit 605fa3362fd7cef0baa2131be32cf44661783d3e > Get rid of TEST_CLEANUP > > Seems we should remove two lines of the testcase as below otherwise it > can't be compile. OK, thanks! I'll send V3 next Monday, in case somebody has other comments ;) > > BTW, I tested it on patched kernel it can works well and Bug reproduced > with unpatched kernel. Thanks! Regards, Xiaoguang Wang > > Thanks, > Li Wang > > On Wed, 2015-02-04 at 16:59 +0800, Xiaoguang Wang wrote: >> This data corruption fixed by: > ... >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "usctest.h" <=========== remove >> +#include "test.h" >> +#include "safe_macros.h" >> + >> +#define MNTPOINT "mntpoint" >> +#define FS_BLOCKSIZE 1024 > ... >> + >> +static void cleanup(void) >> +{ >> + TEST_CLEANUP; <============ remove >> + >> + if (chdir("..")) >> + tst_resm(TWARN | TERRNO, "chdir('..') failed"); >> + if (mount_flag && tst_umount(MNTPOINT) < 0) >> + tst_resm(TWARN | TERRNO, "umount device:%s failed", device); >> + if (device) >> + tst_release_device(NULL, device); >> + tst_rmdir(); >> +} > > . > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list