From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Yd7gq-0006jx-9C for ltp-list@lists.sourceforge.net; Wed, 01 Apr 2015 01:43:32 +0000 Received: from [59.151.112.132] (helo=heian.cn.fujitsu.com) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1Yd7gp-0001QY-48 for ltp-list@lists.sourceforge.net; Wed, 01 Apr 2015 01:43:32 +0000 Message-ID: <551B4C2F.3040108@cn.fujitsu.com> Date: Wed, 1 Apr 2015 09:38:55 +0800 From: "gux.fnst" MIME-Version: 1.0 References: <1427787975-10668-1-git-send-email-gux.fnst@cn.fujitsu.com> <551AB4B5.4020902@oracle.com> In-Reply-To: <551AB4B5.4020902@oracle.com> Subject: Re: [LTP] [PATCH 1/6] lib6/runcc.c: use TCONF instead of TBROK when no C compiler is present List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Alexey Kodanev Cc: ltp-list@lists.sourceforge.net On 03/31/2015 10:52 PM, Alexey Kodanev wrote: > Hi! > On 03/31/2015 10:46 AM, Xing Gu wrote: >> Signed-off-by: Xing Gu >> --- >> testcases/network/lib6/runcc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/testcases/network/lib6/runcc.c b/testcases/network/lib6/runcc.c >> index 91a0b16..3a89598 100644 >> --- a/testcases/network/lib6/runcc.c >> +++ b/testcases/network/lib6/runcc.c >> @@ -93,7 +93,7 @@ int runcc(char *tname, char *filename0, char *program) >> cflags, filename0, filename); >> es = system(cmd); >> if (WEXITSTATUS(es) == 127) { >> - tst_resm(TBROK, "can't run C compiler: \"%s\"", cmd); >> + tst_resm(TCONF, "can't run C compiler: \"%s\"", cmd); >> if (unlink(filename) < 0) >> tst_resm(TWARN, "%s; unlink \"%s\" failed: %s", tname, >> filename, strerror(errno)); > > Why not 'tst_brkm(TCONF, ...)', do we need to proceed further? > The function "runcc" has created a file named "filename" before executing "cmd" command, so I think we should delete this file after tst_resm(TCONF,...). Regards, Xing Gu > Thanks, > Alexey > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list