Re: [LTP] [PATCH] syscalls/fallocate04: add new fallocate() test

[Alexey Kodanev <alexey.kodanev@oracle.com>]

On 04/13/2015 04:42 PM, Alexey Kodanev wrote:
> Hi!
> On 04/13/2015 05:33 AM, Xiaoguang Wang wrote:
>>> +
>>> +#define SEEK_HOLE			4
>>> +#define FALLOC_FL_KEEP_SIZE		0x01
>>> +#define FALLOC_FL_PUNCH_HOLE		0x02
>>> +#define FALLOC_FL_COLLAPSE_RANGE	0x08
>>> +#define FALLOC_FL_ZERO_RANGE		0x10
>> What about something like this:
>> #ifndef	FALLOC_FL_KEEP_SIZE	4
>> #define	 FALLOC_FL_KEEP_SIZE	4
>> #endif
>> In case, glibc have already defines these macro now or in future.
> Redefinition with the same values doesn't produce any warnings, but on
> the other hand what if we want to know when they are different?

In case glibc defines them as '1', etc. it will produce a warning, so 
it's better take your advice.

Best regards,
Alexey


------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list