Re: [LTP] [PATCH 1/6] lib6/runcc.c: use TCONF instead of TBROK when no C compiler is present

["gux.fnst" <gux.fnst@cn.fujitsu.com>]

On 04/01/2015 03:15 PM, Alexey Kodanev wrote:
> Hi!
> On 04/01/2015 04:38 AM, gux.fnst wrote:
>>>>       if (WEXITSTATUS(es) == 127) {
>>>> -        tst_resm(TBROK, "can't run C compiler: \"%s\"", cmd);
>>>> +        tst_resm(TCONF, "can't run C compiler: \"%s\"", cmd);
>>>>           if (unlink(filename) < 0)
>>>>               tst_resm(TWARN, "%s; unlink \"%s\" failed: %s", tname,
>>>>                    filename, strerror(errno));
>>>
>>> Why not 'tst_brkm(TCONF, ...)', do we need to proceed further?
>>>
>>
>> The function "runcc" has created a file named "filename" before
>> executing "cmd" command, so I think we should delete this file
>> after tst_resm(TCONF,...).
>>
>
> So, there is temp test directory... you could pass some cleanup function to tst_brkm().

Here we only remove the "filename" file, so I think it is not necessary to
create a cleanup function for this operation.`

Regards,
Xing Gu

>
> Thanks,
> Alexey
>
>

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list