From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 2/2] pkey: add test for memory protection keys
Date: Mon, 1 Jul 2019 03:23:26 -0400 (EDT) [thread overview]
Message-ID: <553049750.30838144.1561965806395.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAEemH2d-Hyhg5Xo+Q66C3MKvMv3pOnXDKtFYkuZpi6ZUEgC2DA@mail.gmail.com>
----- Original Message -----
> On Wed, Jun 26, 2019 at 5:59 PM Jan Stancek <jstancek@redhat.com> wrote:
>
> >
> > ...
> > >
> > > If a system(e.g PowerKVM guest) configured with NO huge page support,
> > then
> > > the file '/proc/sys/vm/nr_hugepages' exist but EOPNOTSUPP to read/write.
> > In
> > > this key01, perhaps I shouldn't use the "/proc/.../nr_hugepages" to
> > detect
> > > that at the beginning.
> > >
> > > Seems the correct way is to use "/sys/kernel/mm/hugepages/" for huge page
> > > detecting and leave the SAFE_FILE_* still in setup(). Because we need to
> > > catch the "/proc/.../nr_hugepages" open/close or read/write issue in
> > > testing.
> >
> > That should work, I see we used that in some tests already.
> >
>
> Thanks, should I format new patch v5? or any more comments?
Yes, please send v5.
prev parent reply other threads:[~2019-07-01 7:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 7:15 [LTP] [PATCH v4 1/2] pkey: add syscall numbers for pkey Li Wang
2019-06-26 7:15 ` [LTP] [PATCH v4 2/2] pkey: add test for memory protection keys Li Wang
2019-06-26 8:19 ` Jan Stancek
2019-06-26 9:40 ` Li Wang
2019-06-26 9:59 ` Jan Stancek
2019-07-01 7:11 ` Li Wang
2019-07-01 7:23 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553049750.30838144.1561965806395.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox