From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Yq6A1-0001b9-WD for ltp-list@lists.sourceforge.net; Wed, 06 May 2015 20:43:18 +0000 Received: from userp1040.oracle.com ([156.151.31.81]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1Yq6A1-0001I4-0M for ltp-list@lists.sourceforge.net; Wed, 06 May 2015 20:43:17 +0000 Message-ID: <554A7CCB.5030601@oracle.com> Date: Wed, 06 May 2015 23:42:51 +0300 From: Alexey Kodanev MIME-Version: 1.0 References: <1430907502-30493-1-git-send-email-weijg.fnst@cn.fujitsu.com> <1430907502-30493-2-git-send-email-weijg.fnst@cn.fujitsu.com> In-Reply-To: <1430907502-30493-2-git-send-email-weijg.fnst@cn.fujitsu.com> Subject: Re: [LTP] [PATCH 2/3] kernel/syscalls/fallocate: specify size needs check List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: "Wei, Jiangang" , ltp-list@lists.sourceforge.net Hi, On 05/06/2015 01:18 PM, Wei,Jiangang wrote: > Compare size_t size elements with file data and check > if it's excpeted. > This patch depends on bff5968. > > Signed-off-by: Wei,Jiangang > --- > testcases/kernel/syscalls/fallocate/fallocate04.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/testcases/kernel/syscalls/fallocate/fallocate04.c b/testcases/kernel/syscalls/fallocate/fallocate04.c > index a6d1159..2da0bcd 100644 > --- a/testcases/kernel/syscalls/fallocate/fallocate04.c > +++ b/testcases/kernel/syscalls/fallocate/fallocate04.c > @@ -174,7 +174,7 @@ static void test02(void) > fill_tst_buf(exp_buf); > memset(exp_buf + block_size, 0, block_size); > > - check_file_data(exp_buf); > + check_file_data(exp_buf, sizeof(exp_buf)/sizeof(exp_buf[0])); Thank you for fixing it. We could you use size variables already defined for 'exp_buf[buf_size]'. > > tst_resm(TPASS, "test-case succeeded"); > } > @@ -214,7 +214,7 @@ static void test03(void) > fill_tst_buf(exp_buf); > memset(exp_buf + block_size - 1, 0, block_size + 2); > > - check_file_data(exp_buf); > + check_file_data(exp_buf, sizeof(exp_buf)/sizeof(exp_buf[0])); > Also buf_size variable here. > tst_resm(TPASS, "test-case succeeded"); > } > @@ -250,7 +250,7 @@ static void test04(void) > memcpy(exp_buf, tmp_buf, block_size); > memcpy(exp_buf + block_size, tmp_buf + size, block_size); > > - check_file_data(exp_buf); > + check_file_data(exp_buf, sizeof(exp_buf)/sizeof(exp_buf[0])); > 'size' variable here. > tst_resm(TPASS, "test-case succeeded"); > } Now test04 fails because I forgot to set adjacent two bytes in 'exp_buf' to zero in test04(), it could be fixed as follows: @@ -250,8 +249,8 @@ static void test04(void) memcpy(exp_buf, tmp_buf, block_size); memcpy(exp_buf + block_size, tmp_buf + size, block_size); - - check_file_data(exp_buf); + exp_buf[block_size - 1] = exp_buf[block_size] = '\0'; + check_file_data(exp_buf, size); tst_resm(TPASS, "test-case succeeded"); } I think it would be better to merge fallocate04 fixes in a single patch. Thanks, Alexey ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list