Re: [LTP] [PATCH v2 1/6] lib6/runcc.c: Cleanup

[Alexey Kodanev <alexey.kodanev@oracle.com>]

Hi,
On 02.06.2015 15:21, Zeng Linggang wrote:
>    *   Copyright (c) International Business Machines  Corp., 2001
> + *	05/2005 written by David L Stevens
>    *
>    *   This program is free software;  you can redistribute it and/or modify
>    *   it under the terms of the GNU General Public License as published by
> @@ -13,19 +13,12 @@
>    *   the GNU General Public License for more details.
>    *
>    *   You should have received a copy of the GNU General Public License
> - *   along with this program;  if not, write to the Free Software
> - *   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + *   along with this program;  if not, write to the Free Software Foundation,
> + *   Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>    */

You could use modern form rather then reordering the old, see 
http://www.gnu.org/licenses/gpl-howto.en.html.

You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.

>   
>   /*
>    * runcc.a - common functions for lib6 testing

It is quite obvious, remove it as well.

>   
> -char *filetmpl = "/tmp/%.*s_XXXXXX";
> +static char *filetmpl = "/tmp/%.*s_XXXXXX";

Rather static const char filetmpl[] = "/tmp/%.*s_XXXXXX";
The same applies for the other changed variables in the patch.

Best regards,
Alexey


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list